Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ERR_INVALID_PARAMETER in animation.gd #1676

Merged
merged 1 commit into from
Aug 12, 2023

Conversation

endaye
Copy link
Contributor

@endaye endaye commented Aug 11, 2023

Fixed an error in animation.gd.

Problem

image

Solution

@Jowan-Spooner
Copy link
Collaborator

Hey thank you for the PR! I didn't think this would be necessary due to the ONE_SHOT connections (so it should disconnect before it comes up the next time).
But if you encountered the error message and this fixes it, while maintaining the same functionality, that is great. I'll test it in a moment and merge after.

@Jowan-Spooner
Copy link
Collaborator

Looks good to me! Thanks.

@Jowan-Spooner Jowan-Spooner merged commit 7a2e842 into dialogic-godot:main Aug 12, 2023
@endaye
Copy link
Contributor Author

endaye commented Aug 12, 2023

Yes. When you connect a ONE_SHOT signal twice before you emit it, it will return the error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants