Fix CSV breaking when new rows get added. #1863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open closed timeline again.
Jowan-Spooner
approved these changes
Nov 2, 2023
CakeVR
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes two bugs when updating CSV using the Translation feature.
Bug Cause
When a new line of text gets added to the CSV, eg. by adding a Text Event, it did not add trailing commas for each available locale.
Additionally, updating CSVs closed the current timeline node, but did not re-open it.
Bug Fix
We count the number of locale entries and count each entry per CSV row.
For every missing entry, we add trailing commas.
We also save the resource at the beginning of the method and once finished, silently open it again.
Additional Information
Changes comments and their positioning, adds a newlines were it helps readability.
In the future, this code section will require a full refactoring, as the overall method is quite complex.