Update Auto-Advance #1867
Merged
Update Auto-Advance #1867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change signals to `toggled`. Change Auto-Advance method approach to variables. Rename Auto-Advance enable flags.
Jowan-Spooner
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
@CakeVR Looks great so far. However I think it can be even better.
Most of my comments are on
- removing unnecessary autoadvance in method names
- some comment corrections
- removing setter methods in favor of direct set() declaration on variable declaration.
Feel free to disagree with me if you think I'm wrong.
|
Lgtm. Thanks! |
Invertex
pushed a commit
to Invertex/dialogic
that referenced
this pull request
Jan 26, 2024
* Fix incorrect description of `DialogicAutoAdvance`. * Add `per_word_delay` variable. * Add `per_character_delay` variable. * Add variables for ignoring characters. * Add `await_playing_voice` variable. * Add `fixed_delay` variable. * Add `override_delay_for_current_event` variable. * Add `waiting_for_next_event` variable. * Add `waiting_for_system` variable. * Add `waiting_for_user_input` variable. * Add `delay_modifier` variable. * Remove `get_autoadvance_info` method. * Rename variables and signals. * Adjust API of Auto-Advance and Auto-Skip. Change signals to `toggled`. Change Auto-Advance method approach to variables. Rename Auto-Advance enable flags. * Move `ProjectSettings` configuration to `_init`. * Add missing word. * Move `class_name` before documentation. * Fixed variable doc referencing itself. * Improve signal receiver name. * Rename `start_autoadvance` to `start`. * Simplify method naming. * Remove setters for stacking enable flags. * Move `class_name` up. * Use delay override variable directly. * Rename `_emit_autoadvance_enabled`. * Remove invalid access. * Use correct user-input enable flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to change Auto-Advance's API and internals to match Auto-Skip.
Tasks to do: