Improve CSV File Handling #1887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move CSV file handling to class. Reduce code repetition. Update project settings when changing translation file mode. Add save file location mode.
Remove invalid translation file paths. Find the the correct translation file ending.
Use `WRITE` instead of `READ`.
Jowan-Spooner
approved these changes
Nov 10, 2023
|
Lgtm. Thanks! |
Invertex
pushed a commit
to Invertex/dialogic
that referenced
this pull request
Jan 26, 2024
* Use `ProjectSettings` to get settings. * Rework updating CSV. Move CSV file handling to class. Reduce code repetition. Update project settings when changing translation file mode. Add save file location mode. * Relocate tooltips on translation settings. * Improve translation settings text. * Add event statistics to `DialogicCsvFile` * Properly clear and write to the file. * Improve collecting translations. Remove invalid translation file paths. Find the the correct translation file ending. * Improve tooltip wording. * Improve tooltip. * Create the file if it does not exist. Use `WRITE` instead of `READ`. * Improve node naming. * Update tooltips. * Conditionally disable the `Update CSV` button. * Add `_verify_translation_file` method. * Minor variable improvements. * Minor style guide improvements. * Add trailing newline at the file end. * Fix `class_name` and `extends` order. * Fix comment text. * Remove `print`. * Add extra newline between methods. * Reorder translation settings and reword labels. * Improve text on translation settings page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to improves handling CSV file creation and improve code quality.
Save file modeallowing to save CSVs next to timelines or inside theTranslation file path.Update CSV filesnot finding all timelines outside ofTranslation file path.Save file modesetting to signal receivers saving settings.Update CSV filesifTranslation file pathis required and invalid.Tasks left to do:
Update CSV filesbutton, ifTranslation file pathis empty and a project CSV file is used or the save file mode requires it.