Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null assignment to String #1924

Conversation

CakeVR
Copy link
Collaborator

@CakeVR CakeVR commented Nov 22, 2023

Problem

When there was no character in the current state info, it would fall back to null.

Solution

Adds an empty string as fallback value.

Context

This PR aims to fix #1923.
Therefore, I want to hear confirmation on the fixed behaviour.

@Jowan-Spooner Jowan-Spooner merged commit a8f075b into dialogic-godot:main Nov 22, 2023
@Jowan-Spooner
Copy link
Collaborator

Thanks!

@CakeVR CakeVR deleted the fix-null-assignment-to-character-path branch January 1, 2024 21:47
Invertex pushed a commit to Invertex/dialogic that referenced this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when playing a timeline.
2 participants