Style & Layout Rework (adds StyleLayers) #1925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes a lot of the implementation a lot cleaner.
Jowan-Spooner
added
Feature✨
Needs testing
Set's the style name as expected when creating style resource (based on the file name).
Invertex
pushed a commit
to Invertex/dialogic
that referenced
this pull request
Jan 26, 2024
* First commit with a ton of style-editor work * Improvements to realizing layouts * Add inheritance (and other stuff) * Another Update * Make Styles actual Resources This makes a lot of the implementation a lot cleaner. * Rename and Remove stuff * Remove some trash * Remove old layouts * Remove my testing stuff * A bunch of renames and a new textbubble style! * Small Style adjustments * Fix for character styles and style event UI * Fixes to hint tooltips * Add many preview images to premade styles & layers * A bunch of fixes * More fixes * Small UX improvements * Another UX improvement Set's the style name as expected when creating style resource (based on the file name). * Small Addition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes massive changes to how layouts & styles work.
It introduces actual DialogicStyle resources.
It also makes it so each style isn't just one scene with a bunch of settings but a collection of scenes (one base_scene and a bunch of layer scenes) and settings for each. This has the advantage of allowing combining custom and premade stuff in layers.
For this to work these are the new important things:
DialogicStyle (Resource): A resource that stores a bunch of packed scenes and export overrides for those scenes (dictionaries)
DialogicStyleLayer (Resource): Mostly used for convenience. Only used as part of a DialogicStyle.
DialogicLayoutBase (Node): New node that all dialogic layout base scenes should extend from.
DialogicLayoutLayer (Node): New node that all dialogic layout layer scenes should extend from.
Right now all parts of the visual novel layout have been converted to the new layers (some have gained a bunch of new settings, yay!).
A speaker-textbox-layer can somewhat replace the old RPG-layout.
The "style-part-browser" has been updated. It can now browse for a specific type of part (a style-preset, a layout base scene, a layout layer scene). Everything is missing proper preview pictures right now.
A layout can be converted to a custom scene entirely or just one of the layers. This will automatically copy the layer scene and all it's dependencies into a specified folders.
If the whole layout is made custom it will ONLY actually make the base scene custom and instance all the orginal layer scenes. From there something like Right-Click "Make Local" can be used.