Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hardcoded 'partfile_alt_format' #1001

Closed
farhan-ct opened this issue Mar 5, 2024 Discussed in #1000 · 2 comments
Closed

hardcoded 'partfile_alt_format' #1001

farhan-ct opened this issue Mar 5, 2024 Discussed in #1000 · 2 comments

Comments

@farhan-ct
Copy link

farhan-ct commented Mar 5, 2024

Discussed in #1000

Originally posted by farhan-ct March 5, 2024
Hi,

I observed that the option 'partfile_alt_format' is hardcoded as false, which results in not considering fixed chunks made using gnu split. Is there any specific reason why this was done?

@copy

@copy
Copy link
Owner

copy commented Mar 16, 2024

It was a prototype that was never used. The current format has the advantage that you can't get the chunk size wrong (you'd get 404s).

Feel free to send a PR to expose the alternative format, if you really want to use it.

@farhan-ct
Copy link
Author

This is what I am using currently, same as mentioned in main.js demo page

  1. I edited the built libv86.js file and hardcoded partfile_alt_format to true.
  2. I split my image using split -b 1M -a8 -d --additional-suffix .img <image-name>.img <some-prefix>-
  hda: {
    url: <.img url>,
    size,
    async: true,
    fixed_chunk_size: 1024 * 1024,
    use_parts: true,
  }

and it's working great.

I am closing this issue for now, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants