Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coq-flocq does not install sources #396

Closed
vzaliva opened this issue Aug 20, 2018 · 8 comments
Closed

coq-flocq does not install sources #396

vzaliva opened this issue Aug 20, 2018 · 8 comments

Comments

@vzaliva
Copy link
Contributor

vzaliva commented Aug 20, 2018

The install target of coq-flocq does not install sources. Most opam-installed coq libraries install sources (.v files) along with compiled versions (.vo). This is convenient as it allows to examine definitions from IDE (ProofGeneral) during development.

@Zimmi48
Copy link
Member

Zimmi48 commented Aug 20, 2018

cc @silene

@vzaliva
Copy link
Contributor Author

vzaliva commented Aug 29, 2018

I've created a patch to solve this issue. Unfortunately, Flocq is hosted at gitlab.inria.fr which does not allow pull requests from external contributors :(

--- flocq-3.0.0/Remakefile.in	2018-04-04 05:28:08.000000000 -0700
+++ flocq/Remakefile.in	2018-08-29 11:32:06.877169752 -0700
@@ -127,6 +127,7 @@
 	mkdir -p @libdir@
 	for d in Core Calc Prop IEEE754 Pff; do mkdir -p @libdir@/$d; done
 	for f in $(OBJS); do cp $f @libdir@/${f#src/}; done
+	for f in $(FILES); do cp src/$f @libdir@/${f}; done
 	( cd src && find . -type d -name ".coq-native" -exec cp -RT "{}" "@libdir@/{}" \; )
 
 EXTRA_DIST = \

@Zimmi48
Copy link
Member

Zimmi48 commented Aug 30, 2018

You can still create an account, and open an issue on the Flocq repository with your patch. Maybe it has better chances of grabbing @silene's attention.

@vzaliva
Copy link
Contributor Author

vzaliva commented Aug 30, 2018

@vzaliva
Copy link
Contributor Author

vzaliva commented Jan 15, 2019

My patch was applied at gitlab.inria.fr 3 months ago. However, this version has not made its way into opam repository so we could not benefit from it.

@Zimmi48
Copy link
Member

Zimmi48 commented Jan 15, 2019

I think @silene is prioritizing releasing the next version of Coq over releasing a new version of Flocq for now.

@clarus
Copy link
Contributor

clarus commented Aug 15, 2019

@vzaliva It seems to me that the latest version of coq-flocq does install the .v. Thus your patch got published. Do you confirm?

@vzaliva
Copy link
Contributor Author

vzaliva commented Aug 15, 2019

Yes, the sources are correctly installed in coq-flocq-3.2.0

@vzaliva vzaliva closed this as completed Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants