Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Error in the definition of the function that adv loss in the vocoder. #3153

Closed
jiaweiru opened this issue Nov 7, 2023 · 1 comment
Closed

[Bug] Error in the definition of the function that adv loss in the vocoder. #3153

jiaweiru opened this issue Nov 7, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@jiaweiru
Copy link

jiaweiru commented Nov 7, 2023

Describe the bug

There is a simple bug here, real_loss and fake_loss will be overwritten instead of being cumulative, which will result in the real_loss and fake_loss in the return value being related only to the last discriminator.

To Reproduce

It's a simple mistake that doesn't need to be reproduced.

Expected behavior

No response

Logs

No response

Environment

No environmental description needed

Additional context

No response
@jiaweiru jiaweiru added the bug Something isn't working label Nov 7, 2023
@erogol
Copy link
Member

erogol commented Nov 8, 2023

That is a perfect catch. You are awesome @jiaweiru !

@erogol erogol closed this as completed in cc6e9fc Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@erogol @jiaweiru