Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Checking type of default values #22

Open
WeberJulian opened this issue Aug 30, 2021 · 0 comments
Open

[feature request] Checking type of default values #22

WeberJulian opened this issue Aug 30, 2021 · 0 comments

Comments

@WeberJulian
Copy link
Contributor

I think it would be great if coqpit checked the type of default parameters.
In this commit, we fix a problem we had with coqui-TTS, where the value inside of the config was silently set to 0 (int part of the value) because the type was wrongly set to int instead of float. Edresson/Coqui-TTS@fe5da49

It would have been nice to have a warning saying that the default value parsed was rounded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant