In Random Window Discriminator, feats is an empty list

[akashrajkn]

In Random Window discriminator, feats list is defined, but it is not updated. Is this by design?

    def forward(self, x, c):
        scores = []
        feats = []
        # unconditional pass
        for (window_size, layer) in zip(self.window_sizes,
                                        self.unconditional_discriminators):
            index = np.random.randint(x.shape[-1] - window_size)

            score = layer(x[:, :, index:index + window_size])
            scores.append(score)

        # conditional pass
        for (window_size, layer) in zip(self.window_sizes,
                                        self.conditional_discriminators):
            frame_size = window_size // self.hop_length
            lc_index = np.random.randint(c.shape[-1] - frame_size)
            sample_index = lc_index * self.hop_length
            x_sub = x[:, :,
                      sample_index:(lc_index + frame_size) * self.hop_length]
            c_sub = c[:, :, lc_index:lc_index + frame_size]

            score = layer(x_sub, c_sub)
            scores.append(score)
        return scores, feats

Also, thank you for this project. It's awesome :)

[erogol]

feats is just a place holder to match the MelganDiscriminator outputs to be able to combine them.
But if you need the feats, maybe you can consider a PR :)

Thanks for your good words 👍

[akashrajkn]

Thanks for the reply.

But if you need the feats, maybe you can consider a PR :)

Great, I'll test whether feature loss helps and then make a PR

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. You might also look our discussion channels.