Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement rule reload mechanism #151

Closed
jptosso opened this issue Feb 4, 2022 · 3 comments
Closed

Implement rule reload mechanism #151

jptosso opened this issue Feb 4, 2022 · 3 comments
Assignees

Comments

@jptosso
Copy link
Member

jptosso commented Feb 4, 2022

Maybe we could replace waf.Rules pointer in runtime without affecting the users but I'm not sure if it might panic in some cases

Other mechanism would be to remove waf.Rules and replace it with:

func (w *Waf) Rules() *RuleGroup {
  w.rgMux.RLock()
  defer w.rgMux.RUnlock()
  return w.rules
}

That way we could lock .Rules() whenever we are refreshing the rules with something like wwaf.SetRules(someRuleGroup).

@github-actions
Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Mar 14, 2022
@syinwu
Copy link
Member

syinwu commented Mar 15, 2022

This is still happening.

@jptosso
Copy link
Member Author

jptosso commented Mar 15, 2022

Maybe this problem should be solved by the connectors and not by Coraza ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants