Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 9 issue #604

Closed
wontone18 opened this issue Feb 12, 2022 · 9 comments
Closed

Laravel 9 issue #604

wontone18 opened this issue Feb 12, 2022 · 9 comments

Comments

@wontone18
Copy link

  • Corcel Version: 5.0
  • Framework Name & Version: 9.0
  • PHP Version: 8.1
  • Database Driver & Version:

Description:

   Problem 1
- Root composer.json requires jgrossi/corcel 5.0 -> satisfiable by jgrossi/corcel[v5.0.0].
- jgrossi/corcel v5.0.0 requires illuminate/database ^8.0 -> found illuminate/database[v8.0.0, ..., 8.x-dev] but it conflicts with your root composer.json require (^9.0).

Steps To Reproduce:

Its not working with laravel 9.0. I am thinking it creating conflict with the database.

@bumbummen99
Copy link
Contributor

bumbummen99 commented Feb 12, 2022

#603

jgrossi/corcel v5.0.0 requires illuminate/database ^8.0

^8.0 does include every upper version until excluding 9.0

@wontone18
Copy link
Author

#603

jgrossi/corcel v5.0.0 requires illuminate/database ^8.0

^8.0 does include every upper version until excluding 9.0

have u try it with laravel 9?

@bumbummen99
Copy link
Contributor

#603
jgrossi/corcel v5.0.0 requires illuminate/database ^8.0
^8.0 does include every upper version until excluding 9.0

have u try it with laravel 9?

Yes i did just for you now and it is working fine. Please read my last comment for information on what the actual issue you have included in the OP is. You can get more information here:
https://semver.org/
https://getcomposer.org/doc/articles/versions.md

@wontone18
Copy link
Author

sure i will check it tonight

@wontone18
Copy link
Author

wontone18 commented Feb 12, 2022

#603
jgrossi/corcel v5.0.0 requires illuminate/database ^8.0
^8.0 does include every upper version until excluding 9.0

have u try it with laravel 9?

Yes i did just for you now and it is working fine. Please read my last comment for information on what the actual issue you have included in the OP is. You can get more information here: https://semver.org/ https://getcomposer.org/doc/articles/versions.md

My php version is 8.1.1 and amazing how it works in your side because illuminate/database:^8.0 only support php ^7.3. And latest "illuminate/database": "^9.0" works with php 8.1.1.

Problem 1
   - jgrossi/corcel[v5.1.0, ..., v5.1.1] require illuminate/database ^8.0 -> found illuminate/database[v8.0.0, ..., 8.x-dev] but these were not loaded, likely because it conflicts with another require.
   - Root composer.json requires jgrossi/corcel ^5.1 -> satisfiable by jgrossi/corcel[v5.1.0, v5.1.1].

You can also try re-running composer require with an explicit version constraint, e.g. "composer require jgrossi/corcel:*" to figure out if any version is installable, or "composer require jgrossi/corcel:^2.1" if you know which you need.

@bumbummen99
Copy link
Contributor

Of course you have to raise the version constraint for all illuminate packages to also include ^9.0 in composer.json of this package, this is what i tried to explain in my answers to your issue. You will have to use the version provided in #603 or do your own fork until this has been merged. Of course it does not work with Laravel 9, the version constraint does restrict that it as i have explained - that is totally intended as L9 could be a breaking change.

What you said about illuminate/database is not true, please look at https://packagist.org/packages/illuminate/database#v8.12.0

To verify yourself that it does work, simply clone this repository, edit composer.json and raise all illuminate to ^9 and testbench to 7, then composer install and run php vendor/bin/phpunit and tests will run just fine.

@bumbummen99
Copy link
Contributor

Also this issue is a duplicate of #602

@wontone18
Copy link
Author

Of course you have to raise the version constraint for all illuminate packages to also include ^9.0 in composer.json of this package, this is what i tried to explain in my answers to your issue. You will have to use the version provided in #603 or do your own fork until this has been merged. Of course it does not work with Laravel 9, the version constraint does restrict that it as i have explained - that is totally intended as L9 could be a breaking change.

What you said about illuminate/database is not true, please look at https://packagist.org/packages/illuminate/database#v8.12.0

To verify yourself that it does work, simply clone this repository, edit composer.json and raise all illuminate to ^9 and testbench to 7, then composer install and run php vendor/bin/phpunit and tests will run just fine.

Thanks its done with the manual way. i also Updated my composer/autoload_psr4.php and installed.json( here also i updated versions) then composer dump-autoload.

i hope you will come with the new version soon

@jgrossi
Copy link
Member

jgrossi commented Feb 13, 2022

hey 👋 support to Laravel 9 included on the new tag v6.0.0

@jgrossi jgrossi closed this as completed Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants