Add black checks to PR github actions #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rizwancordtech this is all done. It was too easy to add it as an extra step so I did this for now to make it a bit cleaner. |
|
How have you tested this? |
encord/orm/dataset.py
Outdated
| class DatasetUserRole(IntEnum): | ||
| ADMIN = 0, | ||
| ADMIN = (0,) |
There was a problem hiding this comment.
Why has this got brackets around it but the 1 below doesn't?
There was a problem hiding this comment.
I assume because of the added ,. I will remove it. That's a good catch
denis-cord
commented
Feb 28, 2022
There was a problem hiding this comment.
@rizwancordtech I have checked that on this PR it runs black. I also checked if some files are not formatted well, that this step reports an error.
Cool thanks |
rizwancordtech
approved these changes
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also does all the necessary formatting.
I have chosen against a
runcommand and instead used an example from the black docs. If we wanted aruncommand we would need to do thepoetry installincluding dev dependencies.