Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log A Warning When Getting AccountInfo By Name #43

Closed
opticyclic opened this issue Aug 29, 2019 · 2 comments
Closed

Log A Warning When Getting AccountInfo By Name #43

opticyclic opened this issue Aug 29, 2019 · 2 comments

Comments

@opticyclic
Copy link
Contributor

If I create accounts with the same name on different nodes then share one of them to another node I can mistakenly get the wrong account when getting AccountInfo by Name.

This is essentially the scenario in the javadocs:
https://github.com/corda/accounts/blob/master/workflows/src/main/kotlin/com/r3/corda/lib/accounts/workflows/services/AccountService.kt#L82-L90

For that reason a Warning should probably be logged when calling that method:

https://github.com/corda/accounts/blob/master/workflows/src/main/kotlin/com/r3/corda/lib/accounts/workflows/services/KeyManagementBackedAccountsService.kt#L53-L57

@roger-that-dev
Copy link

Thanks, will address this

@roger-that-dev
Copy link

See commit here: 67ef5b8

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants