Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yakumo upgrade 忽略某个(些)工作区执行更新 #15

Closed
CyanChanges opened this issue Jan 30, 2024 · 3 comments
Closed

yakumo upgrade 忽略某个(些)工作区执行更新 #15

CyanChanges opened this issue Jan 30, 2024 · 3 comments
Labels
enhancement New feature or request plugin: upgrade

Comments

@CyanChanges
Copy link

CyanChanges commented Jan 30, 2024

需求

yakumo upgrade 支持忽略某些 workspace 或者文件夹更新依赖

原因

将 koishijs/koishi 和 koishijs/webui clone 到本地之后,
yakumo upgrade 会也会将这两个 repo 的依赖更新.

就会导致我在用 idea Commit & Push 我的插件的时候,
push 到 koishijs/koishi koishijs/webui, 然后就 403 了,
后来, 我将本地的上游改到我 fork 的 koishi 和 webui

但是,
后续接受 koishijs/koishikoishijs/webui 上游修改的时候,
需要手动 Merge 或确认 Rebase (Discard Changes).
不 Commit 也会因为本地有修改导致无法直接拉取
(而且找哪些文件是 koishi/webui repo 的挺麻烦的)
还得 stash 或者 restore

如果 yakumo 支持忽略某些文件夹的 upgrade 依赖,
就不会出现类似问题

@CyanChanges CyanChanges changed the title yakumo upgrade 忽略某个工作区执行更新 yakumo upgrade 忽略某个(些)工作区执行更新 Jan 30, 2024
@shigma shigma added enhancement New feature or request plugin: upgrade labels Jan 30, 2024
@CyanChanges
Copy link
Author

#18

@shigma shigma closed this as completed in 27240d1 Feb 26, 2024
@shigma shigma reopened this Feb 26, 2024
@shigma
Copy link
Member

shigma commented Feb 26, 2024

这个可以做,不过改动可能导致 breaking change,我先描述一下做法。

全部指令忽略特定工作区:

- name: yakumo
  config:
    exclude:
      - path/to/package

特定指令忽略全部工作区(除了 root):

- name: yakumo
- name: yakumo/upgrade
  intercept:
    yakumo:
      exclude:
        - *

这个改动依赖一件事,就是把 yakumo 的插件重新导出,下放到配置文件中,这样才能允许 intercept 写法。

稍后我来进行这个改动。

@shigma
Copy link
Member

shigma commented Feb 26, 2024

不过 breaking 似乎也可以解决,当发现用户调用未注册的内置指令时自动写一下配置文件即可。

@shigma shigma closed this as completed Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request plugin: upgrade
Projects
None yet
Development

No branches or pull requests

2 participants