Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Angular 5 compatibility #3

Closed
slindenberg opened this issue Feb 11, 2018 · 1 comment
Closed

Angular 5 compatibility #3

slindenberg opened this issue Feb 11, 2018 · 1 comment
Assignees
@Cordobo
Milestone
1.1.0

Comments

@slindenberg
Copy link

The 1.0.1 version depends on Angular 4.0.0. Would you mind updating to 5.0.0? I just tested it with 5.2.1 and it works, but the install process prints:

npm WARN angularx-qrcode@1.0.1 requires a peer of @angular/common@^4.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN angularx-qrcode@1.0.1 requires a peer of @angular/core@^4.0.0 but none is installed. You must install peer dependencies yourself.

Thank you.
Cordobo added a commit that referenced this issue Mar 15, 2018
@Cordobo
Angular 5 Support #3
291a923
@Cordobo
Copy link
Owner

Cordobo commented Mar 15, 2018

Angular 5 support ships in Version 1.1.0

@Cordobo Cordobo closed this as completed Mar 15, 2018
@Cordobo Cordobo self-assigned this Mar 15, 2018
@Cordobo Cordobo added this to the 1.1.0 milestone Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cordobo Cordobo

Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
2 participants
@Cordobo @slindenberg