Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add video border radius support #733

Closed
hthetiot opened this issue Jan 5, 2022 · 1 comment
Closed

Add video border radius support #733

hthetiot opened this issue Jan 5, 2022 · 1 comment

Comments

@hthetiot
Copy link
Contributor

hthetiot commented Jan 5, 2022

Description

This library does not support border radius on video tag.

A reference implementation is available here:

Steps to reproduce

Css border radius is ignored on rendered video

Expected results

Video has round corner

Actual results

No round corner on video

@hthetiot hthetiot added this to the 8.0.x milestone Jan 5, 2022
@hthetiot hthetiot modified the milestones: 8.0.x, 10.0.x May 12, 2022
@hthetiot
Copy link
Contributor Author

It's actually implemented see https://github.com/cordova-rtc/cordova-plugin-iosrtc/blob/master/src/PluginMediaStreamRenderer.swift#L251

May need some testing, closing and will re-open if tests on device fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant