Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTCRtpSender not have DTMF properties and createDTMFSender deprecate #739

Closed
3 tasks done
buckun opened this issue Feb 10, 2022 · 4 comments
Closed
3 tasks done

RTCRtpSender not have DTMF properties and createDTMFSender deprecate #739

buckun opened this issue Feb 10, 2022 · 4 comments

Comments

@buckun
Copy link
Contributor

buckun commented Feb 10, 2022

YOU MUST read first!

Please use Community Forum for general technical discussions and questions.

  • I have used Google with the error message or bug in association with the library and Cordova words to make sure the issue I'm reporting is only related to iOSRTC.
  • I have provided steps to reproduce (e.g. using sample app code https://github.com/cordova-rtc/cordova-plugin-iosrtc-sample or updated extra/renderer-and-libwebrtc-tests.js file).
  • I have provided versions of third party library name, ios, Xcode and plugin version and adapter.js version if used.

Note: If the checkboxes above are not checked (which you do after the issue is posted), the issue will be closed, removing this checkbox will result in automatic closed issue.

Versions affected

  • Cordova version (8.1.2):
  • Cordova iOS version (5.1.1):
  • Plugin version (8.0.0):
  • iOS version (15.1.1):
  • Xcode version (13.2.1 - 13C1000):

Description

  • I use iosRTC Plugin version 8.0.0. I see that there is no RTCRtpSender.dtmf properties in the RTCRtpSender sender where I use the RTCRtpSender API. For more information...
  • iosRtc plugin use createDTMFSender. This API is deprecated. For more information..

Steps to reproduce

  • We reproduced when we use sent DTMF sender.

Expected results

  • RTCRtpSender also needs to have DTMF properties

Actual results

  • RTCRtpSender not have DTMF properties

Screen Shot 2022-02-10 at 20 49 02

Screen Shot 2022-02-10 at 21 23 18

@hthetiot
Copy link
Contributor

hthetiot commented Feb 11, 2022

PR welcome, alternatively shim around old API createDTMFSender in the meantime time.

@hthetiot hthetiot added this to the 8.0.x milestone Feb 11, 2022
@hthetiot
Copy link
Contributor

hthetiot commented Mar 2, 2022

May be you can update https://github.com/cordova-rtc/cordova-plugin-iosrtc/blob/master/js/RTCRtpReceiver.js with following changes this should works, then you make a PR and contribute, instead of complaining about specs implementation and ignoring my previous reply.

var RTCDTMFSender = require('./RTCDTMFSender');
...
RTCRtpSender.prototype.dtmf = function() {
return RTCDTMFSender(this._pc, this.track)
};

@hthetiot
Copy link
Contributor

hthetiot commented Apr 8, 2022

Fixed by #743 will add version number here once released

@hthetiot hthetiot closed this as completed Apr 8, 2022
@hthetiot
Copy link
Contributor

Version 8.0.2 fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants