Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(icon-button): fix disabled colors #104

Merged
merged 7 commits into from
Jun 24, 2022
Merged

fix(icon-button): fix disabled colors #104

merged 7 commits into from
Jun 24, 2022

Conversation

Valeri8888
Copy link
Collaborator

Добавила стили и скриншот-тесты для состояния disabled

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@coveralls
Copy link

coveralls commented Jun 17, 2022 •
edited

Pull Request Test Coverage Report for Build 2550793713

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.816%
Totals Coverage Status
Change from base Build 2549078205: 0.0%
Covered Lines: 5432
Relevant Lines: 5936
💛 - Coveralls

v-gevak
v-gevak reviewed Jun 20, 2022
View reviewed changes
packages/icon-button/src/default.module.css Outdated
@@ -60,8 +66,14 @@
}
}

.secondary.component:disabled.loader {
color: var(--icon-button-secondary-base-color);
.component:disabled {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Лучше все view под одним .component:disabled сделать -
.component:disabled {
&.privary{}
&.secondary{}
...
}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

можно и так

@Valeri8888 Valeri8888 requested a review from v-gevak June 20, 2022 06:40
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@EGNKupava EGNKupava merged commit 3f03849 into master Jun 24, 2022
@EGNKupava EGNKupava deleted the fix/iconButton-disabled branch June 24, 2022 08:15
core-ds-bot pushed a commit that referenced this pull request Jun 24, 2022
@semantic-release-bot
chore(release): 27.9.0 [skip ci]
dc7778c 
# [27.9.0](v27.8.1...v27.9.0) (2022-06-24)

### Bug Fixes

* **icon-button:** fix disabled colors ([#104](#104)) ([3f03849](3f03849))

### Features

* **amount-input:** added functionality to enter negative values ([#106](#106)) ([d6b6ca7](d6b6ca7))
@core-ds-bot
Copy link
Collaborator

🎉 This PR is included in version 27.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-gevak v-gevak v-gevak approved these changes

@EGNKupava EGNKupava EGNKupava approved these changes

@Oladii Oladii Oladii approved these changes

@reme3d2y reme3d2y Awaiting requested review from reme3d2y reme3d2y is a code owner

@SiebenSieben SiebenSieben Awaiting requested review from SiebenSieben SiebenSieben is a code owner

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Valeri8888 @core-ds-bot @coveralls @v-gevak @EGNKupava @Oladii