docs: Доки чеклист code review & css-переменные #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Собрана новая демка. |
|
Собрана новая демка. |
SiebenSieben
reviewed
Jul 4, 2022
| @@ -31,69 +33,109 @@ import shadowsIndigo from '!!raw-loader!./shadows-indigo.css'; | |||
| ```css | |||
| @import '@alfalab/core-components/vars'; | |||
| ``` | |||
| Для удобства использования все CSS-переменные экспортируются в виде JS-переменных: | |||
|
|
|||
| Все CSS-переменные можно также экспортировать в виде JS-переменных: | |||
There was a problem hiding this comment.
Думаю, это можно куда-то в конец)
There was a problem hiding this comment.
Я сейчас использую styled-components и прям удобно сверху доков брать этот импорт
SiebenSieben
reviewed
Jul 4, 2022
SiebenSieben
reviewed
Jul 4, 2022
SiebenSieben
reviewed
Jul 4, 2022
SiebenSieben
approved these changes
Jul 4, 2022
|
@Oladii есть что причесать в доках, запиши в бэклог, пожалуйста) |
|
Чуть-чуть воздуха бы добавить в оформление чек-листов)) @Oladii
|
reme3d2y
reviewed
Jul 5, 2022
reme3d2y
reviewed
Jul 5, 2022
docs/15.code-review.stories.mdx
Outdated
| Иначе переменные в сборке не будут работать. | ||
| - При использовании других компонент из библиотеки необходимо следить, | ||
| чтобы импорт начинался с `@alfalab`. | ||
| > При использовании автоимпорта, иногда происходит ошибка ипорта из локальной папки `../component/src`. |
v-gevak
approved these changes
Jul 6, 2022
Valeri8888
approved these changes
Jul 6, 2022
reme3d2y
approved these changes
Jul 7, 2022
|
Собрана новая демка. |
|
🎉 This PR is included in version 28.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀