chore: running bash scripts on windows #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
v-gevak
commented
Jul 11, 2022
v-gevak
commented
- Исправил команду postinstall, так как не работала на OS Windows.
- Добавил пункт в Readme с описанием того, как запускать bash скрипты на OS windows.
SiebenSieben
approved these changes
Jul 11, 2022
v-gevak
force-pushed
the
chore/bash_scripts_windows
branch
from
d1269aa
to
060ae7c
Compare
|
Собрана новая демка. |
Pull Request Test Coverage Report for Build 2689726344
💛 - Coveralls |
EGNKupava
approved these changes
Jul 11, 2022
v-gevak
force-pushed
the
chore/bash_scripts_windows
branch
from
060ae7c
to
993f300
Compare
|
Собрана новая демка. |
SiebenSieben
approved these changes
Jul 11, 2022
EGNKupava
approved these changes
Jul 11, 2022
reme3d2y
reviewed
Jul 18, 2022
packages/with-suffix/package.json
Outdated
| @@ -10,7 +10,7 @@ | |||
| "dist" | |||
| ], | |||
| "scripts": { | |||
| "postinstall": "node ./dist/send-stats.js > /dev/null 2>&1 || exit 0" | |||
| "postinstall": "(node -e \"if (!require('fs').existsSync('./dist/send-stats.js')){process.exit(0)}else{require('./dist/send-stats.js')} \")" | |||
There was a problem hiding this comment.
А как send-stats может не существовать?
There was a problem hiding this comment.
send-stats.js в build.sh из bin копируется в dist. Т.е в собранных пакетах он есть, а в самом репо нет.
reme3d2y
approved these changes
Jul 18, 2022
v-gevak
force-pushed
the
chore/bash_scripts_windows
branch
from
993f300
to
c02a00c
Compare
|
Собрана новая демка. |
|
🎉 This PR is included in version 28.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.