-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(icon-view): add aditional path to image and change icon size in addons #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2881503772
💛 - Coveralls |
DaniilStepanko
changed the title
Fix/icon view
fix(icon-view): change icon size in addons
Jul 26, 2022
v-gevak
approved these changes
Jul 28, 2022
DaniilStepanko
changed the title
fix(icon-view): change icon size in addons
fix(icon-view): add aditional path to image and change icon size in addons
Jul 28, 2022
Собрана новая демка. |
reme3d2y
approved these changes
Jul 29, 2022
reme3d2y
reviewed
Jul 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Давай пример еще добавим, а то не очень понятно, что за изменения
DaniilStepanko
force-pushed
the
fix/icon-view
branch
from
July 29, 2022 12:33
ec4633c
to
872defa
Compare
Собрана новая демка. |
Valeri8888
approved these changes
Aug 1, 2022
Собрана новая демка. |
Собрана новая демка. |
Oladii
approved these changes
Aug 2, 2022
SiebenSieben
approved these changes
Aug 17, 2022
EGNKupava
approved these changes
Aug 18, 2022
DaniilStepanko
force-pushed
the
fix/icon-view
branch
from
August 18, 2022 09:47
261876b
to
893bbe4
Compare
Собрана новая демка. |
core-ds-bot
pushed a commit
that referenced
this pull request
Aug 19, 2022
## [30.0.1](v30.0.0...v30.0.1) (2022-08-19) ### Bug Fixes * **icon-view:** add aditional path to image and change icon size in addons ([#170](#170)) ([51c8259](51c8259)) * omit enterKeyHint prop ([#197](#197)) ([72f4946](72f4946)) * **picker-button:** increased css specificity ([#190](#190)) ([e089871](e089871))
🎉 This PR is included in version 30.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Опишите проблему
При добавлении одновременно пропсов backgroundColor и imageUrl в IconView - изображение заменяет фон
Шаги для воспроизведения
Добавить пропсы backgroundColor и imageUrl в IconView
Ожидаемое поведение
Изображение должно быть поверх фона