Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icon-view): add aditional path to image and change icon size in addons #170

Merged
merged 3 commits into from
Aug 19, 2022

Conversation

DaniilStepanko
Copy link
Contributor

Опишите проблему

При добавлении одновременно пропсов backgroundColor и imageUrl в IconView - изображение заменяет фон

Шаги для воспроизведения

Добавить пропсы backgroundColor и imageUrl в IconView

Ожидаемое поведение

Изображение должно быть поверх фона

@coveralls
Copy link

coveralls commented Jul 26, 2022

Pull Request Test Coverage Report for Build 2881503772

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.005%) to 81.78%

Totals Coverage Status
Change from base Build 2880348349: -0.005%
Covered Lines: 5801
Relevant Lines: 6525

💛 - Coveralls

@DaniilStepanko DaniilStepanko changed the title Fix/icon view fix(icon-view): change icon size in addons Jul 26, 2022
@DaniilStepanko DaniilStepanko changed the title fix(icon-view): change icon size in addons fix(icon-view): add aditional path to image and change icon size in addons Jul 28, 2022
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

Copy link
Contributor

@reme3d2y reme3d2y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Давай пример еще добавим, а то не очень понятно, что за изменения

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@SiebenSieben SiebenSieben merged commit 51c8259 into master Aug 19, 2022
@SiebenSieben SiebenSieben deleted the fix/icon-view branch August 19, 2022 05:19
core-ds-bot pushed a commit that referenced this pull request Aug 19, 2022
## [30.0.1](v30.0.0...v30.0.1) (2022-08-19)

### Bug Fixes

* **icon-view:** add aditional path to image and change icon size in addons ([#170](#170)) ([51c8259](51c8259))
* omit enterKeyHint prop ([#197](#197)) ([72f4946](72f4946))
* **picker-button:** increased css specificity ([#190](#190)) ([e089871](e089871))
@core-ds-bot
Copy link
Collaborator

🎉 This PR is included in version 30.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants