feat: new components: TimeInput, DateTimeInput, DateRangeInput #175

blackraydev · 2022-08-01T03:43:09Z

Новые компоненты: TimeInput, DateTimeInput, DateRangeInput

core-ds-bot · 2022-08-01T03:50:03Z

Собрана новая демка.

coveralls · 2022-08-01T03:51:55Z

Pull Request Test Coverage Report for Build 3067420534

292 of 348 (83.91%) changed or added relevant lines in 8 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.3%) to 81.509%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
packages/date-range-input/src/utils/format.ts	20	21	95.24%
packages/time-input/src/utils/format.ts	13	15	86.67%
packages/time-input/src/Component.tsx	25	28	89.29%
packages/date-time-input/src/utils/format.ts	46	60	76.67%
packages/date-time-input/src/Component.tsx	81	98	82.65%
packages/date-range-input/src/Component.tsx	104	123	84.55%

Totals
Change from base Build 3062023670:	-0.3%
Covered Lines:	6657
Relevant Lines:	7491

💛 - Coveralls

core-ds-bot · 2022-08-03T09:10:09Z

Собрана новая демка.

core-ds-bot · 2022-08-03T09:12:18Z

Собрана новая демка.

v-gevak · 2022-08-04T05:04:09Z

Есть баг, что вместо точек можно цифры ввести

v-gevak · 2022-08-04T05:05:43Z

Ну и также есть стандартная проблема с прыжками каретки, если очищать введенное значение не с конца или пытаться ввести что-нибудь в середину.
Это критично здесь? @SiebenSieben @Oladii что думаете?

Oladii · 2022-08-04T14:59:13Z

Ну и также есть стандартная проблема с прыжками каретки, если очищать введенное значение не с конца или пытаться ввести что-нибудь в середину. Это критично здесь? @SiebenSieben @Oladii что думаете?

Кажется что стоит попробовать починить. Возможно отдельной таской.

Но в этой таске определенно нужны плейсхолдеры, без них компонент теряет смысл.

core-ds-bot · 2022-08-05T13:08:41Z

Собрана новая демка.

SiebenSieben · 2022-08-09T15:25:30Z

packages/time-input/src/index.module.css

@@ -0,0 +1,3 @@
+.component {
+    min-width: 328px;


Кажется, это случайная ширина инпута в макете, не? Зачем ему быть таким широким)

SiebenSieben · 2022-08-09T15:26:26Z

packages/date-time-input/src/index.module.css

+}
+
+.input {
+    width: 354px;


Тут тоже странно, вроде у Влада в спеке ничего нет про минимальную ширину

SiebenSieben · 2022-08-09T15:27:12Z

packages/date-range-input/src/index.module.css

+}
+
+.input {
+    width: 353px;


И здесь)

SiebenSieben · 2022-08-09T15:42:29Z

В DateTimeInput с пикером можем закрывать пикер после выбора даты?

SiebenSieben · 2022-08-09T16:05:41Z

Но в этой таске определенно нужны плейсхолдеры, без них компонент теряет смысл.

@blackraydev оцени, пожалуйста, такую реализацию:
https://taiga-ui.dev/components/input-date-range

(часть плейсхолдера остаётся по мере ввода)

core-ds-bot · 2022-08-26T06:24:00Z

Собрана новая демка.

v-gevak · 2022-09-12T05:36:22Z

packages/date-range-input/package.json

+    },
+    "peerDependencies": {
+        "react": "^16.9.0 || ^17.0.1",
+        "react-dom": "^16.9.0 || ^17.0.1"


v-gevak · 2022-09-12T05:36:57Z

packages/date-range-input/package.json

+        "@alfalab/core-components-icon-button": "^4.2.2",
+        "@alfalab/core-components-calendar": "^5.5.8",
+        "@alfalab/core-components-popover": "^5.7.5",
+        "classnames": "^2.2.6"


v-gevak · 2022-09-12T05:40:44Z

packages/date-time-input/package.json

+        "directory": "dist"
+    },
+    "peerDependencies": {
+        "react": "^16.9.0 || ^17.0.1",


core-ds-bot · 2022-09-12T11:11:50Z

Собрана новая демка.

core-ds-bot · 2022-09-12T11:15:18Z

Собрана новая демка.

core-ds-bot · 2022-09-12T11:27:27Z

Собрана новая демка.

core-ds-bot · 2022-09-12T13:58:55Z

Собрана новая демка.

core-ds-bot · 2022-09-13T00:19:24Z

Собрана новая демка.

core-ds-bot · 2022-09-13T00:20:47Z

Собрана новая демка.

SiebenSieben · 2022-09-15T09:03:18Z

Надо ширину убрать (то что выше комментили) и вроде ок

changeset-bot · 2022-09-16T02:20:44Z

🦋 Changeset detected

Latest commit: c48078a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages

Name	Type
@alfalab/core-components-calendar	Patch
@alfalab/core-components-date-range-input	Minor
@alfalab/core-components-date-time-input	Minor
@alfalab/core-components-time-input	Minor
@alfalab/core-components-calendar-input	Patch
@alfalab/core-components-calendar-range	Patch
@alfalab/core-components-calendar-with-skeleton	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

core-ds-bot · 2022-09-16T02:40:56Z

Собрана новая демка.

core-ds-bot · 2022-09-16T02:53:45Z

Собрана новая демка.

v-gevak · 2022-09-16T06:39:56Z

packages/gallery/src/component.test.tsx

@@ -267,9 +267,8 @@ describe('Gallery', () => {

            fireEvent.mouseOver(fullscreenButton);

-            await waitFor(
-                () => expect(getByText('Открыть в полноэкранном режиме')).toBeInTheDocument(),
-                { timeout: 2000 },


Нужно вернуть timeout

v-gevak · 2022-09-16T06:40:09Z

packages/input-autocomplete/src/Component.test.tsx

@@ -97,7 +97,7 @@ describe('InputAutocompleteMobile', () => {
                />,
            );

-            await waitFor(() => expect(handleEntered).toHaveBeenCalledTimes(1), { timeout: 2000 });


И тут нужно вернуть timeout

core-ds-bot · 2022-09-16T09:16:10Z

Собрана новая демка.

core-ds-bot · 2022-09-16T10:52:26Z

Собрана новая демка.

core-ds-bot · 2022-09-16T11:37:22Z

Собрана новая демка.

feat: new components: TimeInput, DateTimeInput, DateTimeRange

4f347f3

feat: added features & tests

ea5ef4e

blackraydev marked this pull request as ready for review August 3, 2022 09:01

blackraydev requested review from reme3d2y and SiebenSieben as code owners August 3, 2022 09:01

test: updated tests

ddebadf

fix: review fixes

ce51163

SiebenSieben requested a review from Oladii August 9, 2022 12:50

SiebenSieben reviewed Aug 9, 2022

View reviewed changes

SiebenSieben changed the title ~~feat: new components: TimeInput, DateTimeInput, DateTimeRange~~ feat: new components: TimeInput, DateTimeInput, DateRangeInput Aug 12, 2022

SiebenSieben requested review from EGNKupava and v-gevak August 18, 2022 06:20

blackraydev added 3 commits August 24, 2022 14:44

Merge branch 'master' into feat/time_input_implementation

18a3487

Merge branch 'master' into feat/time_input_implementation

77270fe

fix: build fix

7d89730

Oladii approved these changes Aug 26, 2022

View reviewed changes

v-gevak reviewed Sep 12, 2022

View reviewed changes

blackraydev added 2 commits September 12, 2022 13:53

Merge branch 'master' into feat/time_input_implementation

7fcea5b

chore: updated yarn.lock

aeba7ed

fix: fixed css vars import

45d1015

blackraydev added 2 commits September 13, 2022 02:59

test: updated tests

1f7c554

chore: updated demo

587df22

fix: review fixes

387aec9

Merge branch 'master' into feat/time_input_implementation

71feeb1

v-gevak reviewed Sep 16, 2022

View reviewed changes

fix: review fixes

1d3a30e

v-gevak approved these changes Sep 16, 2022

View reviewed changes

Create fast-dolphins-breathe.md

46d578c

reme3d2y approved these changes Sep 16, 2022

View reviewed changes

chore: chore changes

c48078a

SiebenSieben added the approved label Sep 19, 2022

SiebenSieben merged commit 2643a1d into master Sep 19, 2022

SiebenSieben deleted the feat/time_input_implementation branch September 19, 2022 09:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: new components: TimeInput, DateTimeInput, DateRangeInput #175

feat: new components: TimeInput, DateTimeInput, DateRangeInput #175

blackraydev commented Aug 1, 2022 •

edited by SiebenSieben

core-ds-bot commented Aug 1, 2022

coveralls commented Aug 1, 2022 •

edited

core-ds-bot commented Aug 3, 2022

core-ds-bot commented Aug 3, 2022

v-gevak commented Aug 4, 2022

v-gevak commented Aug 4, 2022 •

edited

Oladii commented Aug 4, 2022 •

edited

core-ds-bot commented Aug 5, 2022

SiebenSieben Aug 9, 2022

SiebenSieben Aug 9, 2022

SiebenSieben Aug 9, 2022

SiebenSieben commented Aug 9, 2022 •

edited

SiebenSieben commented Aug 9, 2022 •

edited

core-ds-bot commented Aug 26, 2022

v-gevak Sep 12, 2022

v-gevak Sep 12, 2022

v-gevak Sep 12, 2022

core-ds-bot commented Sep 12, 2022

core-ds-bot commented Sep 12, 2022

core-ds-bot commented Sep 12, 2022

core-ds-bot commented Sep 12, 2022

core-ds-bot commented Sep 13, 2022

core-ds-bot commented Sep 13, 2022

SiebenSieben commented Sep 15, 2022

changeset-bot bot commented Sep 16, 2022 •

edited

core-ds-bot commented Sep 16, 2022

core-ds-bot commented Sep 16, 2022

v-gevak Sep 16, 2022

v-gevak Sep 16, 2022

core-ds-bot commented Sep 16, 2022

core-ds-bot commented Sep 16, 2022

core-ds-bot commented Sep 16, 2022

feat: new components: TimeInput, DateTimeInput, DateRangeInput #175

feat: new components: TimeInput, DateTimeInput, DateRangeInput #175

Conversation

blackraydev commented Aug 1, 2022 • edited by SiebenSieben

core-ds-bot commented Aug 1, 2022

coveralls commented Aug 1, 2022 • edited

Pull Request Test Coverage Report for Build 3067420534

💛 - Coveralls

core-ds-bot commented Aug 3, 2022

core-ds-bot commented Aug 3, 2022

v-gevak commented Aug 4, 2022

v-gevak commented Aug 4, 2022 • edited

Oladii commented Aug 4, 2022 • edited

core-ds-bot commented Aug 5, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SiebenSieben commented Aug 9, 2022 • edited

SiebenSieben commented Aug 9, 2022 • edited

core-ds-bot commented Aug 26, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

core-ds-bot commented Sep 12, 2022

core-ds-bot commented Sep 12, 2022

core-ds-bot commented Sep 12, 2022

core-ds-bot commented Sep 12, 2022

core-ds-bot commented Sep 13, 2022

core-ds-bot commented Sep 13, 2022

SiebenSieben commented Sep 15, 2022

changeset-bot bot commented Sep 16, 2022 • edited

🦋 Changeset detected

core-ds-bot commented Sep 16, 2022

core-ds-bot commented Sep 16, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

core-ds-bot commented Sep 16, 2022

core-ds-bot commented Sep 16, 2022

core-ds-bot commented Sep 16, 2022

blackraydev commented Aug 1, 2022 •

edited by SiebenSieben

coveralls commented Aug 1, 2022 •

edited

v-gevak commented Aug 4, 2022 •

edited

Oladii commented Aug 4, 2022 •

edited

SiebenSieben commented Aug 9, 2022 •

edited

SiebenSieben commented Aug 9, 2022 •

edited

changeset-bot bot commented Sep 16, 2022 •

edited