Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pure-cell): removed isMultiline prop #182

Merged
merged 12 commits into from
Sep 15, 2022
Merged

feat(pure-cell): removed isMultiline prop #182

merged 12 commits into from
Sep 15, 2022

Conversation

blackraydev
Copy link
Contributor

@blackraydev blackraydev commented Aug 3, 2022 •
edited by SiebenSieben

Убран лишний проп isMultiline. Есть rowLimit, и если его не передавать, ожидается, что текст не будет обрезаться.

@coveralls
Copy link

coveralls commented Aug 3, 2022 •
edited

Pull Request Test Coverage Report for Build 3059913734

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.846%
Totals Coverage Status
Change from base Build 3059227751: 0.0%
Covered Lines: 6270
Relevant Lines: 7048
💛 - Coveralls

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@SiebenSieben
Copy link
Contributor

Надо теперь демку поправить, чтобы не было такого:

image

image

И везде где текст «Если текст дискрипшена или текст кэпшена не помещается в контейнер, отображаем сколько влезло»

@reme3d2y
Copy link
Contributor

Всем же ок будет?

@SiebenSieben
Copy link
Contributor

Всем же ок будет?

Просил Клик, другие вроде ещё не используют

@NatalyaZ
Copy link
Contributor

Мне кажется, параметр isMultiline лишний. Есть rowLimit, и если его не передавать, ожидается, что текст не будет обрезаться.

И как понять, что главнее, если указать оба параметра?

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@blackraydev
feat(pure-cell): major update
ac8f391 
removed isMultiline prop

BREAKING CHANGE: removed isMultiline prop
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@SiebenSieben SiebenSieben changed the title feat(pure-cell): updated isMultiline prop default value feat(pure-cell): removed isMultiline prop Sep 12, 2022
@SiebenSieben
Copy link
Contributor

Сразу после релиза обновить динамополе

@changeset-bot
Copy link

changeset-bot bot commented Sep 14, 2022 •
edited

🦋 Changeset detected

Latest commit: 633ff42

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@alfalab/core-components-pure-cell Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@v-gevak v-gevak merged commit e5cfc1d into master Sep 15, 2022
@v-gevak v-gevak deleted the feat/update_pure_cell_prop branch September 15, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SiebenSieben SiebenSieben SiebenSieben approved these changes

@reme3d2y reme3d2y reme3d2y approved these changes

@v-gevak v-gevak v-gevak approved these changes

@Valeri8888 Valeri8888 Valeri8888 approved these changes

@EGNKupava EGNKupava Awaiting requested review from EGNKupava

@Oladii Oladii Awaiting requested review from Oladii

Assignees
No one assigned
Labels
approved breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@blackraydev @coveralls @core-ds-bot @SiebenSieben @reme3d2y @NatalyaZ @v-gevak @Valeri8888