Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(input): change colors for input in intranet theme #201

Closed
wants to merge 7 commits into from
Closed

fix(input): change colors for input in intranet theme #201

wants to merge 7 commits into from

Conversation

leetvig
Copy link
Contributor

@leetvig leetvig commented Aug 18, 2022

Пофиксил цвета и состояние disabled для input в теме intranet

@coveralls
Copy link

coveralls commented Aug 18, 2022 •
edited

Pull Request Test Coverage Report for Build 2924912690

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.005%) to 81.78%
Files with Coverage Reduction New Missed Lines %
packages/input/src/Component.tsx 3 93.29%
Totals Coverage Status
Change from base Build 2880348349: -0.005%
Covered Lines: 5801
Relevant Lines: 6525
💛 - Coveralls

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@SiebenSieben
Copy link
Contributor

Давай сделаем через box-shadow (аналогично --form-control-error-shadow), сейчас у компонента увеличивается высота

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@funkyscum
Copy link

Для Disable надо цвет текста поставить Secondary, иначе он плохо виден на офисных мониторах

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@SiebenSieben
Copy link
Contributor

SiebenSieben commented Sep 1, 2022 •
edited

@leetvig, поправь конфликт, пожалуйста, вмёрджим

@leetvig
Copy link
Contributor Author

leetvig commented Sep 1, 2022 •
edited

Я еще не закончил) просто тесты отвалиливались, нашел причину. Правлю. Как буду готов поправлю
А с каким коммитом можно смерджить мастер? Чтобы хаски прошел?

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@leetvig leetvig closed this Sep 1, 2022
@leetvig leetvig deleted the fix/input-intranet-colors branch September 1, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reme3d2y reme3d2y reme3d2y approved these changes

@v-gevak v-gevak v-gevak approved these changes

@Valeri8888 Valeri8888 Valeri8888 approved these changes

@funkyscum funkyscum funkyscum approved these changes

@EGNKupava EGNKupava Awaiting requested review from EGNKupava

@SiebenSieben SiebenSieben Awaiting requested review from SiebenSieben SiebenSieben is a code owner

@Oladii Oladii Awaiting requested review from Oladii

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@leetvig @coveralls @core-ds-bot @SiebenSieben @funkyscum @reme3d2y @v-gevak @Valeri8888