feat(calendar-range): added onError callback #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-gevak
requested review from
reme3d2y,
EGNKupava and
SiebenSieben
as code owners
v-gevak
commented
Sep 9, 2022
| @@ -86,13 +87,15 @@ export const CalendarRangeStatic: FC<CalendarRangeStaticProps> = ({ | |||
| ); | |||
|
|
|||
| const [inputFromInvalid, setInputFromInvalid] = useState<boolean>( | |||
| validateInputFromValue(inputFromValue) === false, | |||
| isCompleteDateInput(inputFromValue) && dateFrom === null, | |||
There was a problem hiding this comment.
Привел в соответствие логику определения начального состояния с popover календарем.
Pull Request Test Coverage Report for Build 3021603037
💛 - Coveralls |
2 tasks
|
Собрана новая демка. |
Valeri8888
approved these changes
Sep 12, 2022
SiebenSieben
approved these changes
Sep 12, 2022
reme3d2y
approved these changes
Sep 12, 2022
core-ds-bot
pushed a commit
that referenced
this pull request
Sep 12, 2022
# [31.2.0](v31.1.0...v31.2.0) (2022-09-12) ### Bug Fixes * **base-modal:** Added element matches polyfill for IE11 ([#245](#245)) ([cb95740](cb95740)) * **button:** increased click area of the active state ([#246](#246)) ([8937248](8937248)) * **checkbox-group:** added onBlur and onFocus ([#250](#250)) ([b4a739b](b4a739b)) * **gallery:** fixed swiper height on ios 14 and lower ([#95](#95)) ([9703ca7](9703ca7)) * **input-autocomplete:** add prop for custom input ([#223](#223)) ([632cb7f](632cb7f)) * **intl-phone-input:** fixed on ios 14 and lower ([#94](#94)) ([8b7d3fc](8b7d3fc)) * **pure-cell:** better pure-cell text (ReactNode for value) ([#240](#240)) ([8eea8b0](8eea8b0)) * **radio-group:** added onBlur and onFocus ([#249](#249)) ([68c802c](68c802c)) * renamed default classnames ([#198](#198)) ([bf22bba](bf22bba)) * **select:** removed ssr warning ([#248](#248)) ([d7f4abd](d7f4abd)) ### Features * **calendar-range:** added onError callback ([#253](#253)) ([46e163c](46e163c)) * **form-control:** new input/select label view (outer) ([#177](#177)) ([66beb15](66beb15)) * **toast-plate:** added inverted views ([#243](#243)) ([a527d15](a527d15)) * **vars:** introducing vars bundles ([#192](#192)) ([28c15a4](28c15a4))
|
🎉 This PR is included in version 31.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.