Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pure-cell): resolves #285 #288

Merged
merged 10 commits into from
Oct 18, 2022
Merged

feat(pure-cell): resolves #285 #288

merged 10 commits into from
Oct 18, 2022

Conversation

NatalyaZ
Copy link
Contributor

@NatalyaZ NatalyaZ commented Oct 4, 2022

Описание в #285

@changeset-bot
Copy link

changeset-bot bot commented Oct 4, 2022 •
edited

🦋 Changeset detected

Latest commit: e40550f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@alfalab/core-components-comment Minor
@alfalab/core-components-pure-cell Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@NatalyaZ NatalyaZ changed the title Правки по PureCell и Comment feat(pure-cell): resolves #285 Oct 4, 2022
@coveralls
Copy link

coveralls commented Oct 4, 2022 •
edited

Pull Request Test Coverage Report for Build 3234857876

  • 6 of 22 (27.27%) changed or added relevant lines in 5 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.07%) to 81.419%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/pure-cell/src/components/addon/component.tsx 0 1 0.0%
packages/pure-cell/src/components/amount/component.tsx 0 4 0.0%
packages/pure-cell/src/components/category/component.tsx 2 7 28.57%
packages/pure-cell/src/components/amount-title/component.tsx 1 7 14.29%
Files with Coverage Reduction New Missed Lines %
packages/pure-cell/src/components/amount-title/component.tsx 1 35.0%
packages/pure-cell/src/components/amount/component.tsx 2 25.93%
Totals Coverage Status
Change from base Build 3175478421: -0.07%
Covered Lines: 6679
Relevant Lines: 7516
💛 - Coveralls

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

SiebenSieben
SiebenSieben requested changes Oct 5, 2022
View reviewed changes
packages/pure-cell/src/components/category/component.tsx Outdated Show resolved Hide resolved
packages/pure-cell/src/components/amount/component.tsx
@@ -23,7 +18,7 @@ type Props = {
/**
* Размер денежного значения
*/
view?: 'component' | 'primary-small';
textView?: 'component' | 'primary-small';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Мажорка

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тут и удаление из пропсов amount тоже мажорка

@SiebenSieben
Copy link
Contributor

Надо проверить скрины, упали:
pure-cell-screenshots-direction-horizontal-direction-0-diff

@v-gevak
Copy link
Contributor

v-gevak commented Oct 5, 2022

Снимок экрана 2022-10-05 в 14 38 48

Value и SubValue уехали за границу экрана

@Valeri8888 Valeri8888 self-requested a review October 5, 2022 11:15
@NatalyaZ
Copy link
Contributor Author

NatalyaZ commented Oct 6, 2022

Снимок экрана 2022-10-05 в 14 38 48

Value и SubValue уехали за границу экрана

Спасибо! Исправила. Добавила кейс в тест

@NatalyaZ
Copy link
Contributor Author

NatalyaZ commented Oct 6, 2022

Надо проверить скрины, упали: pure-cell-screenshots-direction-horizontal-direction-0-diff

Да, картинка пододвинулась, потому что отображение минорной части было зашито в компонент AmountTitle, а блоки рисуются флексом (ширина блока уменьшилась). Обновила скриншот

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

v-gevak
v-gevak reviewed Oct 7, 2022
View reviewed changes
updates branch Outdated
@@ -0,0 +1,334 @@
Merge branch 'master' of github.com:core-ds/core-components into feat/pure-cell
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Этот файл удалить нужно

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Удалила

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Нет, файл остался))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не поняла, как так вышло. Сейчас точно удалила

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@SiebenSieben SiebenSieben merged commit 946e1e8 into master Oct 18, 2022
@SiebenSieben SiebenSieben deleted the feat/pure-cell branch October 18, 2022 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SiebenSieben SiebenSieben SiebenSieben approved these changes

@vyushev vyushev vyushev approved these changes

@v-gevak v-gevak v-gevak approved these changes

@Oladii Oladii Oladii approved these changes

@Valeri8888 Valeri8888 Valeri8888 approved these changes

@reme3d2y reme3d2y Awaiting requested review from reme3d2y reme3d2y is a code owner

@EGNKupava EGNKupava Awaiting requested review from EGNKupava

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@NatalyaZ @coveralls @core-ds-bot @SiebenSieben @v-gevak @vyushev @Oladii @Valeri8888