fix(calendar-range): fix divider margin #315
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoVaL0
requested review from
reme3d2y,
v-gevak,
EGNKupava and
SiebenSieben
as code owners
|
Pull Request Test Coverage Report for Build 3295778725
💛 - Coveralls |
|
Собрана новая демка. |
reme3d2y
requested changes
Oct 27, 2022
| @@ -34,6 +34,10 @@ | |||
| } | |||
| } | |||
|
|
|||
| .outerLabel { | |||
| margin-top: 24px; | |||
There was a problem hiding this comment.
Надо подумать, как сделать так, чтобы учитывался размер инпута, иначе опять съедет
There was a problem hiding this comment.
@KoVaL0 будет возможность дотащить?
| @@ -169,6 +169,18 @@ export const CalendarRangePopover: FC<CalendarRangePopoverProps> = ({ | |||
| // eslint-disable-next-line react-hooks/exhaustive-deps | |||
| }, [hasValidateError]); | |||
|
|
|||
| const checkForLabel = () => { | |||
SiebenSieben
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Опишите проблему
Divider в CalendarRange уплывает вверх при наличии label у CalendarInput
Шаги для воспроизведения
Ожидаемое поведение
Ожидается что Divider будет находится по середине с инпутом
Чек лист
Внешний вид
Ожидаемый
Фактический
Дополнительная информация
Реализация не идеальна, можно подумать над более элегантной реализацией