Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: collapsed tabs #336

Merged
merged 6 commits into from
Nov 17, 2022
Merged

feat: collapsed tabs #336

merged 6 commits into from
Nov 17, 2022

Conversation

DaniilStepanko
Copy link
Contributor

Добавлен пропс collapsible, при включении которого не помещающиеся в окне табы сворачиваются в PickerButton.

@changeset-bot
Copy link

changeset-bot bot commented Oct 31, 2022

🦋 Changeset detected

Latest commit: 2b85c30

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@alfalab/core-components-tabs Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@DaniilStepanko DaniilStepanko changed the title Feat/collapsable tabs feat: collapsed tabs Oct 31, 2022
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@coveralls
Copy link

coveralls commented Oct 31, 2022

Pull Request Test Coverage Report for Build 3436284141

  • 94 of 121 (77.69%) changed or added relevant lines in 10 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 79.482%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/tabs/src/components/scrollable-container/Component.tsx 1 2 50.0%
packages/tabs/src/hooks/use-collapsible-elements.ts 31 33 93.94%
packages/tabs/src/components/primary-tablist/Component.tsx 20 25 80.0%
packages/tabs/src/hooks/use-tablist-titles.ts 18 23 78.26%
packages/tabs/src/synthetic-events.ts 3 17 17.65%
Totals Coverage Status
Change from base Build 3435084724: -0.2%
Covered Lines: 6779
Relevant Lines: 7777

💛 - Coveralls

@AlexZJScript
Copy link
Contributor

В canvas`e поставил collapsible в true, но ничего не "схлопывается"(
Снимок экрана 2022-11-01 в 14 48 04

@DaniilStepanko
Copy link
Contributor Author

DaniilStepanko commented Nov 1, 2022

@AlexZJScript да, в канвасе не будет видно, потому что по тз пикер баттон не должен появляться для таблетки и мобильного размера, но для просмотра функционала мы добавили в docs в раздел адаптивность возможность включить пропс

@AlexZJScript
Copy link
Contributor

При переключении с 7 до 10 табов такой баг споймал

2022-11-01.15.25.30.mov

@core-ds core-ds deleted a comment from core-ds-bot Nov 3, 2022
@core-ds core-ds deleted a comment from core-ds-bot Nov 3, 2022
@core-ds core-ds deleted a comment from core-ds-bot Nov 3, 2022
@core-ds core-ds deleted a comment from core-ds-bot Nov 3, 2022
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds core-ds deleted a comment from core-ds-bot Nov 7, 2022
@core-ds core-ds deleted a comment from core-ds-bot Nov 7, 2022
@SiebenSieben
Copy link
Contributor

@OlegMeo

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@DaniilStepanko DaniilStepanko merged commit 5ec8f16 into master Nov 17, 2022
@DaniilStepanko DaniilStepanko deleted the feat/collapsable-tabs branch November 17, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet