Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(picker-button): show default button icon if right addon exists #344

Merged
merged 1 commit into from
Nov 9, 2022
Merged

feat(picker-button): show default button icon if right addon exists #344

merged 1 commit into from
Nov 9, 2022

Conversation

DaniilStepanko
Copy link
Contributor

BREAKING CHANGE: При наличии правого аддона, дефолтная иконка кнопки не исчезает

@changeset-bot
Copy link

changeset-bot bot commented Nov 2, 2022 •
edited

🦋 Changeset detected

Latest commit: 91a57d4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@alfalab/core-components-picker-button Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link

coveralls commented Nov 2, 2022 •
edited

Pull Request Test Coverage Report for Build 3384057519

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 81.498%
Totals Coverage Status
Change from base Build 3367439158: -0.003%
Covered Lines: 6802
Relevant Lines: 7642
💛 - Coveralls

@SiebenSieben
Copy link
Contributor

Добавь демку, пожалуйста

@DaniilStepanko DaniilStepanko force-pushed the feat/picker-button-right-addon-position branch from 8201d34 to 91a57d4 Compare November 3, 2022 08:23
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@v-gevak v-gevak merged commit e3616c0 into master Nov 9, 2022
@v-gevak v-gevak deleted the feat/picker-button-right-addon-position branch November 9, 2022 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SiebenSieben SiebenSieben SiebenSieben approved these changes

@reme3d2y reme3d2y reme3d2y approved these changes

@v-gevak v-gevak v-gevak approved these changes

@EGNKupava EGNKupava EGNKupava approved these changes

@Valeri8888 Valeri8888 Valeri8888 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@DaniilStepanko @coveralls @SiebenSieben @core-ds-bot @reme3d2y @v-gevak @EGNKupava @Valeri8888