Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: доработан скрипт update-usages #395

Merged
merged 1 commit into from
Dec 9, 2022
Merged

chore: доработан скрипт update-usages #395

merged 1 commit into from
Dec 9, 2022

Conversation

v-gevak
Copy link
Contributor

@v-gevak v-gevak commented Dec 5, 2022

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Dec 5, 2022 •
edited

⚠️ No Changeset found

Latest commit: ac44349

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coveralls
Copy link

coveralls commented Dec 5, 2022 •
edited

Pull Request Test Coverage Report for Build 3631243413

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.012%
Totals Coverage Status
Change from base Build 3631212642: 0.0%
Covered Lines: 6990
Relevant Lines: 8046
💛 - Coveralls

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

SiebenSieben
SiebenSieben reviewed Dec 6, 2022
View reviewed changes
.storybook/blocks/component-header/ComponentHeader.tsx Outdated
@@ -66,7 +66,7 @@ export const ComponentHeader: React.FC<ComponentHeaderProps> = ({ name, design,
<Typography.Text view='primary-small' color='secondary'>
Используется в{' '}
<Link
href={`http://digital/design-system-usage/usage-chart?component=${name}`}
href={`http://digital/design-system-usage/usage-chart?component=${usages[name]?.search}`}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

На этой неделе нам digital отключат, давай сразу поменяем на design

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Только design на digital изменить? Или ещё что изменится?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Заменил digital на design

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@v-gevak v-gevak changed the title chore: доработан скрипт update-usages chore: доработан скрипт update-usages Dec 7, 2022
@v-gevak v-gevak merged commit 6834a71 into master Dec 9, 2022
@v-gevak v-gevak deleted the chore/fix_update_usages branch December 9, 2022 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SiebenSieben SiebenSieben SiebenSieben approved these changes

@Valeri8888 Valeri8888 Valeri8888 approved these changes

@reme3d2y reme3d2y Awaiting requested review from reme3d2y reme3d2y is a code owner

@EGNKupava EGNKupava Awaiting requested review from EGNKupava

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@v-gevak @coveralls @core-ds-bot @SiebenSieben @Valeri8888