-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(select): virtual options list #497
Conversation
🦋 Changeset detectedLatest commit: 1c757f0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Pull Request Test Coverage Report for Build 4132488210
💛 - Coveralls |
Собрана новая демка. |
|
||
import styles from './index.module.css'; | ||
|
||
const VIRTUAL_OPTIONS_LIST_THRESHOLD = 30; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Пока так, потом лучше полноценно настроить
packages/select/src/components/base-select-mobile/index.module.css
Outdated
Show resolved
Hide resolved
packages/select/src/components/base-select-mobile/virtual-options-list/Component.tsx
Outdated
Show resolved
Hide resolved
Не забыть changeset) |
Собрана новая демка. |
1ed8227
to
6f44f4d
Compare
Собрана новая демка. |
Собрана новая демка. |
Пофиксил, но тут явно нужно рефакторить компонент