Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(underlay): added new component Underlay #511

Merged
merged 6 commits into from
Feb 16, 2023
Merged

feat(underlay): added new component Underlay #511

merged 6 commits into from
Feb 16, 2023

Conversation

Valeri8888
Copy link
Collaborator

Добавлен новый компонент UnderlayWrapper

@changeset-bot
Copy link

changeset-bot bot commented Feb 7, 2023 •
edited

🦋 Changeset detected

Latest commit: f8cbea1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@alfalab/core-components-underlay Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link

coveralls commented Feb 7, 2023 •
edited

Pull Request Test Coverage Report for Build 4181694560

  • 17 of 17 (100.0%) changed or added relevant lines in 1 file are covered.
  • 112 unchanged lines in 20 files lost coverage.
  • Overall coverage decreased (-0.6%) to 79.925%
Files with Coverage Reduction New Missed Lines %
packages/calendar-input/src/Component.mobile.tsx 1 80.0%
packages/calendar/src/Component.responsive.tsx 1 41.67%
packages/date-range-input/src/Component.mobile.tsx 1 80.0%
packages/date-time-input/src/Component.mobile.tsx 1 80.0%
packages/select/src/components/base-checkmark/Component.tsx 1 37.5%
packages/select/src/components/checkmark/Component.tsx 1 92.31%
packages/input-autocomplete/src/Component.responsive.tsx 2 41.67%
packages/intl-phone-input/src/utils/preparePasteData.ts 2 68.66%
packages/masked-input/src/Component.tsx 2 88.33%
packages/tabs/src/hooks/use-collapsible-elements.ts 2 83.64%
Totals Coverage Status
Change from base Build 4112806775: -0.6%
Covered Lines: 7447
Relevant Lines: 8468
💛 - Coveralls

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

v-gevak
v-gevak suggested changes Feb 8, 2023
View reviewed changes
packages/underlay-wrapper/src/types.ts Outdated Show resolved Hide resolved
packages/underlay-wrapper/src/types.ts Outdated Show resolved Hide resolved
packages/underlay-wrapper/src/Component.tsx Outdated Show resolved Hide resolved
packages/underlay-wrapper/src/Component.tsx Outdated Show resolved Hide resolved
packages/underlay-wrapper/src/Component.tsx Outdated Show resolved Hide resolved
packages/underlay-wrapper/src/border.module.css Outdated Show resolved Hide resolved
packages/underlay-wrapper/src/shadow.module.css Outdated Show resolved Hide resolved
packages/underlay-wrapper/src/Component.tsx Outdated Show resolved Hide resolved
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@Oladii
Copy link
Contributor

Oladii commented Feb 10, 2023

обсудить еще раз имя, андерлей или андерлей враппер.

@Valeri8888 Valeri8888 changed the title feat(underlay-wrapper): added new component UnderlayWrapper feat(underlay): added new component Underlay Feb 13, 2023
@Valeri8888
Copy link
Collaborator Author

обсудить еще раз имя, андерлей или андерлей враппер.

решили что будет андерлей

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

reme3d2y
reme3d2y reviewed Feb 14, 2023
View reviewed changes
packages/underlay/src/Component.tsx Outdated Show resolved Hide resolved
packages/underlay/src/Component.tsx Outdated Show resolved Hide resolved
packages/underlay/src/Component.tsx Outdated Show resolved Hide resolved
packages/underlay/src/Component.tsx Outdated Show resolved Hide resolved
packages/underlay/src/Component.tsx Outdated Show resolved Hide resolved
packages/underlay/src/consts.ts Outdated Show resolved Hide resolved
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@Valeri8888 Valeri8888 merged commit ab88828 into master Feb 16, 2023
@Valeri8888 Valeri8888 deleted the feat/new-component_underlay branch February 16, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SiebenSieben SiebenSieben SiebenSieben approved these changes

@reme3d2y reme3d2y reme3d2y approved these changes

@v-gevak v-gevak v-gevak approved these changes

@Oladii Oladii Oladii approved these changes

@EGNKupava EGNKupava Awaiting requested review from EGNKupava

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Valeri8888 @coveralls @core-ds-bot @Oladii @SiebenSieben @reme3d2y @v-gevak