Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(calendar-input): fixed error ref does not exist on type #522

Merged
merged 1 commit into from
Feb 14, 2023
Merged

fix(calendar-input): fixed error ref does not exist on type #522

merged 1 commit into from
Feb 14, 2023

Conversation

v-gevak
Copy link
Contributor

@v-gevak v-gevak commented Feb 9, 2023

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Feb 9, 2023 •
edited

🦋 Changeset detected

Latest commit: 26ccb6f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@alfalab/core-components-calendar-input Patch
@alfalab/core-components-date-range-input Patch
@alfalab/core-components-date-time-input Patch
@alfalab/core-components-calendar Patch
@alfalab/core-components-input-autocomplete Patch
@alfalab/core-components-calendar-range Patch
@alfalab/core-components-calendar-with-skeleton Patch
@alfalab/core-components-intl-phone-input Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@v-gevak v-gevak linked an issue Feb 9, 2023 that may be closed by this pull request
В компоненте CalendarInput ошибка TS при передаче ref #481
Closed
@coveralls
Copy link

coveralls commented Feb 9, 2023 •
edited

Pull Request Test Coverage Report for Build 4135395983

  • 43 of 50 (86.0%) changed or added relevant lines in 11 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.006%) to 80.463%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/calendar-input/src/Component.mobile.tsx 4 5 80.0%
packages/date-range-input/src/Component.mobile.tsx 3 4 75.0%
packages/date-time-input/src/Component.mobile.tsx 3 4 75.0%
packages/input-autocomplete/src/Component.responsive.tsx 3 4 75.0%
packages/calendar/src/Component.responsive.tsx 3 6 50.0%
Files with Coverage Reduction New Missed Lines %
packages/input-autocomplete/src/Component.responsive.tsx 1 41.67%
Totals Coverage Status
Change from base Build 4134937872: -0.006%
Covered Lines: 7390
Relevant Lines: 8365
💛 - Coveralls

reme3d2y
reme3d2y approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@reme3d2y reme3d2y left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Хм, как мы раньше не замечали?

А во всяких табах, модалках и пр. все ок?

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@v-gevak
Copy link
Contributor Author

v-gevak commented Feb 9, 2023

Хм, как мы раньше не замечали?

А во всяких табах, модалках и пр. все ок?

Поправил еще в нескольких

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@v-gevak v-gevak merged commit 105a8c6 into master Feb 14, 2023
@v-gevak v-gevak deleted the fix/calendar-input-ref branch February 14, 2023 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SiebenSieben SiebenSieben SiebenSieben approved these changes

@reme3d2y reme3d2y reme3d2y approved these changes

@Valeri8888 Valeri8888 Valeri8888 approved these changes

@EGNKupava EGNKupava Awaiting requested review from EGNKupava

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

В компоненте CalendarInput ошибка TS при передаче ref
6 participants
@v-gevak @coveralls @core-ds-bot @SiebenSieben @reme3d2y @Valeri8888