fix(*): tslib added to external dependencies #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-gevak
requested review from
reme3d2y,
EGNKupava and
SiebenSieben
as code owners
🦋 Changeset detectedLatest commit: d6a30d5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 95 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Pull Request Test Coverage Report for Build 4172073315
💛 - Coveralls |
|
Собрана новая демка. |
SiebenSieben
approved these changes
Feb 9, 2023
stepancar
reviewed
Feb 10, 2023
rollup.config.mjs
Outdated
| @@ -40,7 +40,7 @@ const baseConfig = { | |||
| '!src/**/*.d.ts', | |||
| ], | |||
| plugins: [wildcardExternal(['@alfalab/core-components-*/*'])], | |||
| external: [...Object.keys(pkg.dependencies || {}), ...Object.keys(pkg.peerDependencies || {})], | |||
| external: [...Object.keys(pkg.dependencies || {}), ...Object.keys(pkg.peerDependencies || {}), 'tslib'], | |||
There was a problem hiding this comment.
Не нужно ли добавить эту зависимость в dependencies?
v-gevak
force-pushed
the
fix/tslib_external
branch
from
9f02dca
to
4de8ce9
Compare
|
Собрана новая демка. |
Valeri8888
approved these changes
Feb 14, 2023
v-gevak
force-pushed
the
fix/tslib_external
branch
from
4de8ce9
to
d6a30d5
Compare
|
Собрана новая демка. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
После фикса функции хелперы будут импортироваться из tslib, а не встраиваться в код.
