Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(number-input): allowed to call onChange with bad initial state #565

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

v-gevak
Copy link
Contributor

@v-gevak v-gevak commented Feb 28, 2023

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Feb 28, 2023

🦋 Changeset detected

Latest commit: acb6a2c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@alfalab/core-components-number-input Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@v-gevak v-gevak force-pushed the fix/number_input_bad_state branch 2 times, most recently from 058416d to c119442 Compare February 28, 2023 12:00
@coveralls
Copy link

coveralls commented Feb 28, 2023

Pull Request Test Coverage Report for Build 4351462494

  • 42 of 47 (89.36%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 79.959%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/number-input/src/Component.tsx 25 30 83.33%
Totals Coverage Status
Change from base Build 4324593571: 0.1%
Covered Lines: 7715
Relevant Lines: 8755

💛 - Coveralls

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@v-gevak v-gevak force-pushed the fix/number_input_bad_state branch from 91b1316 to acb6a2c Compare March 7, 2023 06:51
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@v-gevak v-gevak merged commit b5c9c8e into master Mar 7, 2023
@v-gevak v-gevak deleted the fix/number_input_bad_state branch March 7, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants