Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pure-input): Добавил дополнительные параметры #577

Closed
wants to merge 1 commit into from

Conversation

msklyarovv
Copy link

Необходимо добавить возможность выбора у компонентов input и inputAutocomplete, типа отображаемой виртуальной клавиатуры (inputmode)

При передаче компонентам параметра defaultInputMode (название изменено от стандартного (inputmode) для верной обработки типов) меняется тип виртуальной клавиатуры

@changeset-bot
Copy link

changeset-bot bot commented Mar 6, 2023

⚠️ No Changeset found

Latest commit: f0da3bd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4344866829

  • 4 of 4 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.004%) to 79.846%

Totals Coverage Status
Change from base Build 4324593571: -0.004%
Covered Lines: 7696
Relevant Lines: 8740

💛 - Coveralls

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@@ -16,7 +16,7 @@ exports[`DateInput Display tests should match snapshot 1`] = `
>
<input
class="input input"
inputmode="decimal"
inputmode="text"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Уже ведь можно прокидывать стандартный inputMode, зачем дополнительно defaultInputMode? Тут сломалось, например

Copy link
Author

@msklyarovv msklyarovv Mar 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Да, увидел что поломалось по тестам. Это поправлю. А по поводу того что уже можно прокидывать. Это везде теперь можно, подскажите, пожалуйста. Например inputAutocomplete -> съест?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В InputAutocomplete -> inputProps={{inputMode: 'numeric'}} работает

@msklyarovv msklyarovv closed this Mar 18, 2023
@msklyarovv msklyarovv deleted the feature/UFRCDPIL-709.add_params branch March 18, 2023 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants