Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modal): new usePortal prop #653

Merged
merged 1 commit into from
May 3, 2023
Merged

feat(modal): new usePortal prop #653

merged 1 commit into from
May 3, 2023

Conversation

v-gevak
Copy link
Contributor

@v-gevak v-gevak commented Apr 27, 2023

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Apr 27, 2023

⚠️ No Changeset found

Latest commit: dba122e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coveralls
Copy link

coveralls commented Apr 27, 2023

Pull Request Test Coverage Report for Build 4821234258

  • 18 of 19 (94.74%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 80.291%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/bottom-sheet/src/component.tsx 14 15 93.33%
Files with Coverage Reduction New Missed Lines %
packages/bottom-sheet/src/component.tsx 1 71.76%
Totals Coverage Status
Change from base Build 4816135074: 0.01%
Covered Lines: 7904
Relevant Lines: 8932

💛 - Coveralls

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@v-gevak v-gevak merged commit f69fd9f into master May 3, 2023
7 checks passed
@v-gevak v-gevak deleted the feat/bottom_sheet_ssr branch May 3, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants