Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(intl-phone-input): add maxDialCodeLength prop #661

Merged
merged 3 commits into from
May 12, 2023
Merged

Conversation

igorokFront
Copy link
Contributor

@igorokFront igorokFront commented May 7, 2023

В Абхазии телефонные номера начинаются с '+7 940' - 5 символов вместе с пробелом и без '+'. Поэтому константа MAX_DIAL_CODE_LENGTH должна быть 5. Но, что бы не сломать поведение там, где коды Абхазии не нужны, добавил пропс maxDialCodeLength с дефолтным значением 4.

@changeset-bot
Copy link

changeset-bot bot commented May 7, 2023

🦋 Changeset detected

Latest commit: a3a44d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@alfalab/core-components-intl-phone-input Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@igorokFront igorokFront changed the title Добавил prop maxDialCodeLength в intl-phone-input feat(intl-phone-input): add maxDialCodeLength prop May 7, 2023
@coveralls
Copy link

coveralls commented May 7, 2023

Pull Request Test Coverage Report for Build 4930507273

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 80.419%

Totals Coverage Status
Change from base Build 4882744743: 0.01%
Covered Lines: 7928
Relevant Lines: 8949

💛 - Coveralls

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@v-gevak v-gevak merged commit c9fe54d into master May 12, 2023
7 checks passed
@v-gevak v-gevak deleted the feat/FASTPAY-2960 branch May 12, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants