Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select-options): fix show footer #671

Merged
merged 1 commit into from
May 25, 2023
Merged

fix(select-options): fix show footer #671

merged 1 commit into from
May 25, 2023

Conversation

sprutkova
Copy link
Contributor

@sprutkova sprutkova commented May 16, 2023

Опишите проблему

SelectMobile - при использовании пропа OptionsList при отрисовки options с помощью VirtualOptionsList появляется футер с кнопками, которого не должно быть

Screenshot 2023-05-16 at 10 43 43

Шаги для воспроизведения

  1. Перейти на страницу Оплату мобильной связи (/payments/mobile) в мобильном разрешении
  2. Нажать на селект Выбор оператора

Ожидаемое поведение

При нажатии на селект должен появится список доступных операторов без футер

Внешний вид

Ожидаемый Фактический
Screenshot 2023-05-16 at 10 59 13 Screenshot 2023-05-16 at 11 00 32

Дополнительная информация

Дополнительная информация

@changeset-bot
Copy link

changeset-bot bot commented May 16, 2023

⚠️ No Changeset found

Latest commit: 48d856b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4989352160

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.008%) to 80.406%

Totals Coverage Status
Change from base Build 4983998705: -0.008%
Covered Lines: 7939
Relevant Lines: 8961

💛 - Coveralls

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@v-gevak v-gevak merged commit 00a2d13 into master May 25, 2023
10 checks passed
@v-gevak v-gevak deleted the fix/select branch May 25, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants