Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: changed position main button to right in modal mobile components #673

Merged
merged 11 commits into from
May 30, 2023
Merged

fix: changed position main button to right in modal mobile components #673

merged 11 commits into from
May 30, 2023

Conversation

Valeri8888
Copy link
Collaborator

изменено положение главной кнопки (теперь справа) в модальных мобильных компонентах

@changeset-bot
Copy link

changeset-bot bot commented May 17, 2023 •
edited

🦋 Changeset detected

Latest commit: c83bb5b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@alfalab/core-components-calendar Minor
@alfalab/core-components-input-autocomplete Minor
@alfalab/core-components-select Minor
@alfalab/core-components-calendar-input Patch
@alfalab/core-components-calendar-range Patch
@alfalab/core-components-calendar-with-skeleton Patch
@alfalab/core-components-date-range-input Patch
@alfalab/core-components-date-time-input Patch
@alfalab/core-components-intl-phone-input Patch
@alfalab/core-components-picker-button Patch
@alfalab/core-components-select-with-tags Patch
@alfalab/core-components-table Patch
@alfalab/core-components-tabs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link

coveralls commented May 17, 2023 •
edited

Pull Request Test Coverage Report for Build 5091229239

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 20 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.09%) to 80.33%
Files with Coverage Reduction New Missed Lines %
packages/select/src/components/options-list/Component.tsx 1 84.71%
packages/calendar-range/src/views/popover.tsx 3 86.99%
packages/calendar-range/src/views/static.tsx 4 90.5%
packages/calendar/src/components/period-slider/Component.tsx 5 78.63%
packages/select/src/components/virtual-options-list/Component.tsx 7 71.22%
Totals Coverage Status
Change from base Build 5006152716: -0.09%
Covered Lines: 7980
Relevant Lines: 9012
💛 - Coveralls

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@v-gevak
Copy link
Contributor

v-gevak commented May 19, 2023

скрин modal-mobile-sticky-snap не обновляется

Он у тебя обновлен же и как раз неверно. Там проблема, кажется, в том, что бордер у футера с анимацией появляется. Тест не всегда успевает его заскринить, попробуй задержку поставить - evaluate: page => page.waitForTimeout(200)

@Valeri8888
Copy link
Collaborator Author

скрин modal-mobile-sticky-snap не обновляется

Он у тебя обновлен же и как раз неудачно. Там проблема, кажется, в том, что граница у футера с анимацией церемонии. Тест не всегда выполняет его заскринить, попробуй зарезервировать доставку - оценить: page => page.waitForTimeout(200)

обновила

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@SiebenSieben
Copy link
Contributor

Не смог в демке селекта найти пример с кнопкой подтверждения, где искать?

@SiebenSieben SiebenSieben requested a review from Oladii May 28, 2023 19:15
@SiebenSieben
Copy link
Contributor

@Oladii надо собрать апрувы дизайн-лидов

@YuriKiyan
Copy link

@Oladii надо собрать апрувы дизайн-лидов

ОК от сайта

@EvKravcov
Copy link

✅ ок

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@Valeri8888
Copy link
Collaborator Author

Не смог в демке селекта найти пример с кнопкой подтверждения, где искать?

в доке пункт "Условие выбора" селект 'Выбор с подтверждением'

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@Oladii
Copy link
Contributor

Oladii commented May 30, 2023

Ждём АО

@Valeri8888 Valeri8888 merged commit e0f84ac into master May 30, 2023
8 checks passed
@Valeri8888 Valeri8888 deleted the fix/mobile-modal_footer branch May 30, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SiebenSieben SiebenSieben SiebenSieben approved these changes

@reme3d2y reme3d2y reme3d2y approved these changes

@v-gevak v-gevak v-gevak approved these changes

@Oladii Oladii Oladii approved these changes

@Andrew-dushes Andrew-dushes Andrew-dushes approved these changes

@EvKravcov EvKravcov EvKravcov approved these changes

@Ackedze Ackedze Ackedze approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet