Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(icon-view): add new shapes #675

Merged
merged 11 commits into from
Jun 1, 2023
Merged

feat(icon-view): add new shapes #675

merged 11 commits into from
Jun 1, 2023

Conversation

reme3d2y
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented May 19, 2023 •
edited

🦋 Changeset detected

Latest commit: f49b4a0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@alfalab/core-components-icon-view Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link

coveralls commented May 19, 2023 •
edited

Pull Request Test Coverage Report for Build 5142871662

  • 23 of 23 (100.0%) changed or added relevant lines in 7 files are covered.
  • 111 unchanged lines in 10 files lost coverage.
  • Overall coverage decreased (-0.7%) to 79.748%
Files with Coverage Reduction New Missed Lines %
packages/base-modal/src/Component.tsx 1 82.15%
packages/base-modal/src/utils.ts 1 90.24%
packages/select/src/components/options-list/Component.tsx 1 86.21%
packages/calendar-range/src/views/popover.tsx 3 86.99%
packages/button/src/Component.tsx 4 89.06%
packages/calendar-range/src/views/static.tsx 4 90.5%
packages/select/src/components/virtual-options-list/Component.tsx 7 71.63%
packages/select/src/components/select-modal-mobile/Component.tsx 17 14.46%
packages/select/src/components/base-select-mobile/Component.tsx 19 66.67%
packages/calendar/src/components/calendar-mobile/Component.tsx 54 12.36%
Totals Coverage Status
Change from base Build 5021241224: -0.7%
Covered Lines: 8087
Relevant Lines: 9179
💛 - Coveralls

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@reme3d2y reme3d2y marked this pull request as ready for review May 21, 2023 07:22
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@SiebenSieben SiebenSieben requested a review from Oladii May 22, 2023 09:05
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@FominSergey5869
Copy link
Contributor

Выпустите бетку пожалуйста

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@reme3d2y
Copy link
Contributor Author

Выпустите бетку пожалуйста

41.7.0-beta.4

SiebenSieben
SiebenSieben reviewed May 28, 2023
View reviewed changes
...s/icon-view/src/__image_snapshots__/icon-view-rectangle-size-border-size-0-border-0-snap.png Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тут иконка вылезает, это ок?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не, должна поидее была обрезаться маской

SiebenSieben
SiebenSieben reviewed May 28, 2023
View reviewed changes
packages/icon-view/src/components/base-shape/component.tsx Outdated
type Border = {
width?: number;
color?: string;
style?: 'solid' | 'dashed' | 'dotted';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Кажется, в дизайн-системе только если dashed может потребоваться. @Oladii, нужен dotted?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dotted точно не нужен)

@Oladii
Copy link
Contributor

Oladii commented May 30, 2023

демка 404(

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@Oladii
Copy link
Contributor

Oladii commented Jun 1, 2023

хм, а в канвасе себя вот так ведёт, а в демке всё ок.
image

@reme3d2y
Copy link
Contributor Author

reme3d2y commented Jun 1, 2023

хм, а в канвасе себя вот так ведёт, а в демке всё ок. image

вроде ок

image

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@Oladii Oladii self-requested a review June 1, 2023 09:50
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@v-gevak v-gevak merged commit 3e1ab16 into master Jun 1, 2023
8 checks passed
@v-gevak v-gevak deleted the feat/sdui-icon-view branch June 1, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SiebenSieben SiebenSieben SiebenSieben approved these changes

@v-gevak v-gevak v-gevak approved these changes

@Oladii Oladii Oladii approved these changes

@Valeri8888 Valeri8888 Valeri8888 approved these changes

@FominSergey5869 FominSergey5869 Awaiting requested review from FominSergey5869

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@reme3d2y @coveralls @core-ds-bot @FominSergey5869 @Oladii @SiebenSieben @v-gevak @Valeri8888