Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(custom-button): fix static colors issue #677

Merged
merged 7 commits into from
Jun 1, 2023
Merged

feat(custom-button): fix static colors issue #677

merged 7 commits into from
Jun 1, 2023

Conversation

reme3d2y
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented May 22, 2023 •
edited

🦋 Changeset detected

Latest commit: b039438

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@alfalab/core-components-custom-button Minor
@alfalab/core-components-themes Minor
@alfalab/core-components-custom-picker-button Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link

coveralls commented May 22, 2023 •
edited

Pull Request Test Coverage Report for Build 5120012170

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 111 unchanged lines in 10 files lost coverage.
  • Overall coverage decreased (-0.7%) to 79.738%
Files with Coverage Reduction New Missed Lines %
packages/base-modal/src/Component.tsx 1 82.15%
packages/base-modal/src/utils.ts 1 90.24%
packages/select/src/components/options-list/Component.tsx 1 86.21%
packages/calendar-range/src/views/popover.tsx 3 86.99%
packages/button/src/Component.tsx 4 89.06%
packages/calendar-range/src/views/static.tsx 4 90.5%
packages/select/src/components/virtual-options-list/Component.tsx 7 71.63%
packages/select/src/components/select-modal-mobile/Component.tsx 17 14.46%
packages/select/src/components/base-select-mobile/Component.tsx 19 66.67%
packages/calendar/src/components/calendar-mobile/Component.tsx 54 12.36%
Totals Coverage Status
Change from base Build 5042243728: -0.7%
Covered Lines: 8068
Relevant Lines: 9160
💛 - Coveralls

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@reme3d2y
Copy link
Contributor Author

41.7.0-beta.3

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

SiebenSieben
SiebenSieben reviewed May 28, 2023
View reviewed changes
.changeset/chilled-bags-end.md Outdated
"@alfalab/core-components-themes": patch
---

feat(custom-button): Добавлены новые цвета и режимы
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Минорка, получается?

@SiebenSieben SiebenSieben requested a review from Oladii May 28, 2023 19:44
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@v-gevak v-gevak merged commit 61ae30e into master Jun 1, 2023
8 checks passed
@v-gevak v-gevak deleted the feat/sdui-button branch June 1, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SiebenSieben SiebenSieben SiebenSieben approved these changes

@v-gevak v-gevak v-gevak approved these changes

@Oladii Oladii Oladii approved these changes

@Valeri8888 Valeri8888 Valeri8888 approved these changes

@FominSergey5869 FominSergey5869 Awaiting requested review from FominSergey5869

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@reme3d2y @coveralls @core-ds-bot @SiebenSieben @v-gevak @Oladii @Valeri8888