Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pure-cell): add vertical align auto for Addon #679

Merged
merged 2 commits into from
May 25, 2023

Conversation

Romkaf
Copy link
Contributor

@Romkaf Romkaf commented May 23, 2023

Опишите проблему

В компоненте PureCell.Addon по умолчанию verticalAlign = 'top'(lign-self: flex-start). При пробрасывании чалдов в Addon, они смыкаются и прижимаются к верху враппера, без возможности растянуть их на всю высоту враппера

Шаги для воспроизведения

  1. Перейти на страницу '...'
  2. Нажать на кнопку '...'

Ожидаемое поведение

Иметь возможность прокинуть проп для растягивания контента Addon на всю высоту контейнера

Чек лист

  • Тесты
  • Документация

Внешний вид

Ожидаемый Фактический
** Ожидаемый ** ** Фактический **

Тестовый стенд

Десктоп (если данных нет оставте блок пустым):

  • OS: MacOS
  • Browser: Safari
  • Version: 10

Смартфон (если данных нет оставте блок пустым):

  • Device: iPhone 6
  • OS: iOS 10
  • Browser: Chrome
  • Version: 65

Дополнительная информация

Дополнительная информация

@changeset-bot
Copy link

changeset-bot bot commented May 23, 2023

🦋 Changeset detected

Latest commit: 21e6ce9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@alfalab/core-components-pure-cell Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5055299624

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.429%

Totals Coverage Status
Change from base Build 5042243728: 0.0%
Covered Lines: 7951
Relevant Lines: 8974

💛 - Coveralls

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@Romkaf Romkaf changed the title Feat/vertical aligh auto feat(pure-cell): add vertical align auto for Addon May 23, 2023
@v-gevak v-gevak merged commit be2ff4f into master May 25, 2023
8 of 9 checks passed
@v-gevak v-gevak deleted the feat/vertical-aligh-auto branch May 25, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants