Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): #2 click called twice in React 18 #683

Merged
merged 1 commit into from
May 29, 2023

Conversation

v-gevak
Copy link
Contributor

@v-gevak v-gevak commented May 24, 2023

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented May 24, 2023

🦋 Changeset detected

Latest commit: 27a5d0f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@alfalab/core-components-select Patch
@alfalab/core-components-input-autocomplete Patch
@alfalab/core-components-intl-phone-input Patch
@alfalab/core-components-picker-button Patch
@alfalab/core-components-select-with-tags Patch
@alfalab/core-components-table Patch
@alfalab/core-components-tabs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5068263920

  • 18 of 22 (81.82%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 80.483%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/select/src/components/base-select-mobile/Component.tsx 8 12 66.67%
Totals Coverage Status
Change from base Build 5042243728: 0.05%
Covered Lines: 7957
Relevant Lines: 8976

💛 - Coveralls

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@reme3d2y
Copy link
Contributor

Кажется этот костыль пока более предпочтительный :D

@v-gevak v-gevak merged commit 4852d26 into master May 29, 2023
7 checks passed
@v-gevak v-gevak deleted the fix/select_twice_click_2 branch May 29, 2023 05:37
v-gevak added a commit that referenced this pull request May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants