Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(select): js scrollbar replaced with css #699

Closed
wants to merge 1 commit into from

Conversation

v-gevak
Copy link
Contributor

@v-gevak v-gevak commented Jun 1, 2023

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jun 1, 2023

🦋 Changeset detected

Latest commit: a1d0750

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@alfalab/core-components-skeleton Minor
@alfalab/core-components-select Minor
@alfalab/core-components-calendar-with-skeleton Patch
@alfalab/core-components-input-autocomplete Patch
@alfalab/core-components-intl-phone-input Patch
@alfalab/core-components-picker-button Patch
@alfalab/core-components-select-with-tags Patch
@alfalab/core-components-table Patch
@alfalab/core-components-custom-picker-button Patch
@alfalab/core-components-tabs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@v-gevak v-gevak force-pushed the feat/select-css-scrollbar branch from 058ad63 to 7e1afc3 Compare June 1, 2023 06:43
@core-ds-bot
Copy link
Collaborator

core-ds-bot commented Jun 1, 2023

Bundle size report

Entry point Size (minified)
tabs/desktop.js 185.66 (-24.34 KB)
tabs/index.js 186.67 (-23.33 KB)
tabs/mobile.js 185.79 (-24.21 KB)
tabs/responsive.js 186.7 (-23.30 KB)
table/index.js 182.34 (-27.66 KB)
select/index.js 175.91 (-24.09 KB)
select/mobile.js 132.52 (-67.48 KB)
select/responsive.js 163.84 (-36.16 KB)
select-with-tags/index.js 178.35 (-31.65 KB)
picker-button/desktop.js 175.43 (-24.57 KB)
picker-button/index.js 176.91 (-23.09 KB)
picker-button/mobile.js 175.09 (-24.91 KB)
picker-button/responsive.js 176.9 (-23.10 KB)
intl-phone-input/index.js 690.81 (-29.19 KB)
input-autocomplete/desktop.js 176.61 (-23.39 KB)
input-autocomplete/index.js 181.88 (-28.12 KB)
input-autocomplete/mobile.js 181.43 (-28.57 KB)
input-autocomplete/responsive.js 181.86 (-28.14 KB)
gallery/index.js 206.82 (-3.18 KB)
date-range-input/index.js 222.26 (+2.26 KB🔺)
date-range-input/responsive.js 222.27 (+2.27 KB🔺)
custom-picker-button/desktop.js 178.35 (-31.65 KB)
custom-picker-button/index.js 180.13 (-29.87 KB)
custom-picker-button/mobile.js 178.35 (-31.65 KB)
custom-picker-button/responsive.js 180.14 (-29.86 KB)
chart/index.js 436.01 (-3.99 KB)
calendar/index.js 164.84 (+4.84 KB🔺)
calendar/mobile.js 162.92 (+2.92 KB🔺)
calendar/responsive.js 162.92 (+2.92 KB🔺)
calendar-with-skeleton/index.js 164.04 (+4.04 KB🔺)

@v-gevak v-gevak force-pushed the feat/select-css-scrollbar branch from 7e1afc3 to d04dafe Compare June 1, 2023 06:52
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@Oladii Oladii self-requested a review June 2, 2023 09:13
@v-gevak v-gevak added the paused label Jun 2, 2023
@v-gevak v-gevak force-pushed the feat/select-css-scrollbar branch from d04dafe to 7563940 Compare June 2, 2023 10:01
@coveralls
Copy link

coveralls commented Jun 2, 2023

Pull Request Test Coverage Report for Build 5154423830

  • 36 of 36 (100.0%) changed or added relevant lines in 6 files are covered.
  • 14 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 79.565%

Files with Coverage Reduction New Missed Lines %
packages/scrollbar/src/Component.tsx 14 65.14%
Totals Coverage Status
Change from base Build 5153695137: -0.1%
Covered Lines: 8100
Relevant Lines: 9210

💛 - Coveralls

@v-gevak v-gevak force-pushed the feat/select-css-scrollbar branch from 7563940 to a1d0750 Compare June 2, 2023 10:16
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@SiebenSieben
Copy link
Contributor

Припарковано, ждёт @Oladii

@v-gevak v-gevak closed this Jul 25, 2023
@v-gevak v-gevak deleted the feat/select-css-scrollbar branch July 25, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants