Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(*): remove responsive entry point (calendar, calendar-input, date… #702

Merged
merged 1 commit into from
Aug 7, 2023
Merged

feat(*): remove responsive entry point (calendar, calendar-input, date… #702

merged 1 commit into from
Aug 7, 2023

Conversation

v-gevak
Copy link
Contributor

@v-gevak v-gevak commented Jun 5, 2023

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jun 5, 2023 •
edited

🦋 Changeset detected

Latest commit: 278afa4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@alfalab/core-components-calendar-input Major
@alfalab/core-components-calendar Major
@alfalab/core-components-date-range-input Major
@alfalab/core-components-date-time-input Major
@alfalab/core-components-calendar-range Patch
@alfalab/core-components-calendar-with-skeleton Patch

Not sure what this means? Click here to learn what changesets are.

[Click here if you're a maintainer who wants to add another changeset to this PR](https://github.com/core-ds/core-components/new/feat/calendar_refactor?filename=.changeset/red-falcons-invite.md&value=---%0A%22%40alfalab%2Fcore-components-calendar-input%22%3A%20patch%0A%22%40alfalab%2Fcore-components-calendar-range%22%3A%20patch%0A%22%40alfalab%2Fcore-components-calendar-with-skeleton%22%3A%20patch%0A%22%40alfalab%2Fcore-components-calendar%22%3A%20patch%0A%22%40alfalab%2Fcore-components-date-input%22%3A%20patch%0A---%0A%0Afeat(*)%3A%20remove%20responsive%20entry%20point%20(calendar%2C%20calendar-input%2C%20date%E2%80%A6%0A)

@core-ds-bot
Copy link
Collaborator

core-ds-bot commented Jun 5, 2023 •
edited

Bundle size report

Entry point Size (minified)
date-time-input/desktop.js 126.97 (-93.17 KB)
date-time-input/responsive.js 0 (-220.51 KB)
date-range-input/desktop.js 128.58 (-93.21 KB)
date-range-input/responsive.js 0 (-222.17 KB)
calendar/responsive.js 0 (-162.70 KB)
calendar/shared.js 44.2 (+44.20 KB🔺)
calendar-with-skeleton/index.js 61.43 (-102.35 KB)
calendar-input/desktop.js 127.49 (-93.20 KB)
calendar-input/responsive.js 0 (-221.06 KB)
calendar-input/shared.js 60.87 (+60.87 KB🔺)

@coveralls
Copy link

coveralls commented Jun 5, 2023 •
edited

Pull Request Test Coverage Report for Build 5175805959

  • 45 of 45 (100.0%) changed or added relevant lines in 16 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 79.753%
Totals Coverage Status
Change from base Build 5174457479: 0.05%
Covered Lines: 8115
Relevant Lines: 9210
💛 - Coveralls

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

SiebenSieben
SiebenSieben reviewed Aug 3, 2023
View reviewed changes
.changeset/modern-houses-relate.md
'@alfalab/core-components-date-time-input': major
---

Удалена responsive точка входа. (В проектах нужно заменить импорт @alfalab/core-components-calendar/responsive на @alfalab/core-components-calendar)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Может в ченджлогах допишем про кодмод?

@v-gevak v-gevak requested a review from EGNKupava as a code owner August 7, 2023 06:16
@v-gevak v-gevak merged commit 65ac3bc into master Aug 7, 2023
6 of 8 checks passed
@v-gevak v-gevak deleted the feat/calendar_refactor branch August 7, 2023 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SiebenSieben SiebenSieben SiebenSieben approved these changes

@reme3d2y reme3d2y reme3d2y approved these changes

@Valeri8888 Valeri8888 Valeri8888 approved these changes

@EGNKupava EGNKupava Awaiting requested review from EGNKupava

Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@v-gevak @core-ds-bot @coveralls @SiebenSieben @reme3d2y @Valeri8888