feat(tag): make onClick method params required #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lewsha02
requested review from
reme3d2y,
v-gevak and
SiebenSieben
as code owners
🦋 Changeset detectedLatest commit: dcbafd2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Pull Request Test Coverage Report for Build 5409689043
💛 - Coveralls |
|
Собрана новая демка. |
reme3d2y
approved these changes
Jun 29, 2023
Valeri8888
approved these changes
Jun 29, 2023
SiebenSieben
approved these changes
Jun 29, 2023
|
Собрана новая демка. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Опишите проблему
В пропе onClick у компонента Tag параметры event и payload являются необязательными. В то время как в компоненте CheckboxGroup в пропе onChange они же являются обязательными. Не получается использовать один и тот же обработчик клика для CheckboxGround и Tag.
Ожидаемое поведение
Иметь возможность использовать один хэндлер и для CheckboxGround, и для Tag
Внешний вид