Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(calendar-input): add onCalendarClose and onCalendarOpen callbacks #756

Merged
merged 1 commit into from
Aug 2, 2023
Merged

feat(calendar-input): add onCalendarClose and onCalendarOpen callbacks #756

merged 1 commit into from
Aug 2, 2023

Conversation

v-gevak
Copy link
Contributor

@v-gevak v-gevak commented Jul 21, 2023

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jul 21, 2023 •
edited

🦋 Changeset detected

Latest commit: 3e391bb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@alfalab/core-components-calendar-input Minor
@alfalab/core-components-calendar-range Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@v-gevak v-gevak linked an issue Jul 21, 2023 that may be closed by this pull request
Невозможно прокинуть проп onClose для компонента календаря в CalendarInput #751
Closed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5618649838

  • 44 of 46 (95.65%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 79.691%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/calendar-input/src/components/calendar-input/Component.tsx 44 46 95.65%
Files with Coverage Reduction New Missed Lines %
packages/calendar-input/src/components/calendar-input/Component.tsx 1 90.46%
Totals Coverage Status
Change from base Build 5610938754: 0.01%
Covered Lines: 8125
Relevant Lines: 9225
💛 - Coveralls

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@Romkaf Romkaf self-requested a review July 21, 2023 08:43
@Romkaf
Copy link
Contributor

Romkaf commented Jul 21, 2023

Можно попросить в рамках данного пра добавить также проп хендлер на открытие календаря?

@v-gevak v-gevak force-pushed the fix/calendar-input-onClose branch from b4854c1 to b403e82 Compare July 26, 2023 07:37
@v-gevak v-gevak requested a review from EGNKupava as a code owner July 26, 2023 07:37
@v-gevak v-gevak changed the title fix(calendar-input): fixed onClose callback feat(calendar-input): add onCalendarClose and onCalendarOpen callbacks Jul 26, 2023
@v-gevak
Copy link
Contributor Author

v-gevak commented Jul 26, 2023

Можно попросить в рамках данного пра добавить также проп хендлер на открытие календаря?

Добавил

@Romkaf
Copy link
Contributor

Romkaf commented Jul 26, 2023

Спасибо!

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@v-gevak v-gevak merged commit 7eb6fbb into master Aug 2, 2023
1 of 8 checks passed
@v-gevak v-gevak deleted the fix/calendar-input-onClose branch August 2, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SiebenSieben SiebenSieben SiebenSieben approved these changes

@Romkaf Romkaf Romkaf approved these changes

@EGNKupava EGNKupava EGNKupava approved these changes

@Valeri8888 Valeri8888 Valeri8888 approved these changes

@reme3d2y reme3d2y Awaiting requested review from reme3d2y reme3d2y is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
7 participants
@v-gevak @coveralls @core-ds-bot @Romkaf @SiebenSieben @EGNKupava @Valeri8888